utils/ssh: Update to use latest go.crypto

utils/ssh: Update to use latest go.crypto

Upstream go.crypto has a cleaned up ssh package in r192
and beyond. This has a few interface changes we need to
adapt to, but should make testing easier in future.

Also bumps dependencies.tsv to go.crypto tip.

https://code.launchpad.net/~gz/juju-core/gosshnew_1312940/+merge/217308

(do not edit description out of merge proposal)

[gz, 2014-04-25 22:17:30]

Please take a look.

[axw, 2014-04-26 02:09:29]

LGTM, with a few naming changes

Thanks for doing that, I keep on meaning to do it and then promptly forget.

https://codereview.appspot.com/95770045/diff/1/utils/ssh/authorisedkeys.go
File utils/ssh/authorisedkeys.go (left):

https://codereview.appspot.com/95770045/diff/1/utils/ssh/authorisedkeys.go#ol...
utils/ssh/authorisedkeys.go:48: return nil, fmt.Errorf("invalid authorized_key
%q", line)
Include the ParseAuthorizedKey error in the message?

https://codereview.appspot.com/95770045/diff/1/utils/ssh/ssh_gocrypto.go
File utils/ssh/ssh_gocrypto.go (right):

https://codereview.appspot.com/95770045/diff/1/utils/ssh/ssh_gocrypto.go#newc...
utils/ssh/ssh_gocrypto.go:84: conn         *ssh.Client
s/conn/client/
(and wherever else we refer to Client as conn)
?

https://codereview.appspot.com/95770045/diff/1/utils/ssh/ssh_gocrypto.go#newc...
utils/ssh/ssh_gocrypto.go:152: conn.Conn.Close()
ssh.Client embeds Conn, so conn.Close (or client.Close) would be better IMO

https://codereview.appspot.com/95770045/diff/1/utils/ssh/ssh_gocrypto_test.go
File utils/ssh/ssh_gocrypto_test.go (right):

https://codereview.appspot.com/95770045/diff/1/utils/ssh/ssh_gocrypto_test.go...
utils/ssh/ssh_gocrypto_test.go:31: Listener net.Listener
s/Listener/listener/
?
(I would prefer we don't export fields unless we need to for reflection or
whatever.)

https://codereview.appspot.com/95770045/diff/1/utils/ssh/ssh_gocrypto_test.go...
utils/ssh/ssh_gocrypto_test.go:154: c.Assert(string(out), gc.Equals, "abc
value\n")
Yay! Thanks.

[gz, 2014-04-26 17:11:49]

Please take a look.

https://codereview.appspot.com/95770045/diff/1/utils/ssh/authorisedkeys.go
File utils/ssh/authorisedkeys.go (left):

https://codereview.appspot.com/95770045/diff/1/utils/ssh/authorisedkeys.go#ol...
utils/ssh/authorisedkeys.go:48: return nil, fmt.Errorf("invalid authorized_key
%q", line)
On 2014/04/26 02:09:29, axw wrote:
> Include the ParseAuthorizedKey error in the message?

Was going to errgo wrap it, but the error we get is always "ssh: no key found"
which would actually make our message *worse* if we included it.

https://codereview.appspot.com/95770045/diff/1/utils/ssh/ssh_gocrypto.go
File utils/ssh/ssh_gocrypto.go (right):

https://codereview.appspot.com/95770045/diff/1/utils/ssh/ssh_gocrypto.go#newc...
utils/ssh/ssh_gocrypto.go:84: conn         *ssh.Client
On 2014/04/26 02:09:29, axw wrote:
> s/conn/client/
> (and wherever else we refer to Client as conn)
> ?

Done.

https://codereview.appspot.com/95770045/diff/1/utils/ssh/ssh_gocrypto.go#newc...
utils/ssh/ssh_gocrypto.go:152: conn.Conn.Close()
On 2014/04/26 02:09:29, axw wrote:
> ssh.Client embeds Conn, so conn.Close (or client.Close) would be better IMO

Done.

https://codereview.appspot.com/95770045/diff/1/utils/ssh/ssh_gocrypto_test.go
File utils/ssh/ssh_gocrypto_test.go (right):

https://codereview.appspot.com/95770045/diff/1/utils/ssh/ssh_gocrypto_test.go...
utils/ssh/ssh_gocrypto_test.go:31: Listener net.Listener
On 2014/04/26 02:09:29, axw wrote:
> s/Listener/listener/
> ?
> (I would prefer we don't export fields unless we need to for reflection or
> whatever.)

Okay. I guess really we don't need client in this struct, but I'll leave that
addition for now.