Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(142)

Issue 9575043: code review 9575043: syscall: prefer PATH environment variable in bootstrap ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by mikio
Modified:
12 years, 1 month ago
Reviewers:
iant
CC:
golang-dev, dave_cheney.net, iant
Visibility:
Public.

Description

syscall: prefer PATH environment variable in bootstrap scripts

Patch Set 1 : diff -r 2d4825868d95 https://code.google.com/p/go #

Patch Set 2 : diff -r 9d60132d7784 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/pkg/syscall/mksyscall.pl View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/mksyscall_windows.pl View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/mksysctl_openbsd.pl View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/mksysnum_darwin.pl View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/mksysnum_freebsd.pl View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/mksysnum_linux.pl View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/mksysnum_netbsd.pl View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/syscall/mksysnum_openbsd.pl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years, 1 month ago (2013-05-20 09:59:59 UTC) #1
dave_cheney.net
This sounds reasonable, which systems have you found the default perl to be insufficient ?
12 years, 1 month ago (2013-05-20 10:17:06 UTC) #2
mikio
Perhaps It depends on package systems but NetBSD+pkgsrc, for example. On Mon, May 20, 2013 ...
12 years, 1 month ago (2013-05-20 10:30:44 UTC) #3
iant
LGTM
12 years, 1 month ago (2013-05-20 13:39:54 UTC) #4
mikio
12 years, 1 month ago (2013-05-20 14:19:06 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=9b75b7eb2191 ***

syscall: prefer PATH environment variable in bootstrap scripts

R=golang-dev, dave, iant
CC=golang-dev
https://codereview.appspot.com/9575043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b