Issue 9570043: code review 9570043: net/http: add another Hijacker test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9570043: code review 9570043: net/http: add another Hijacker test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bradfitz

Modified:
12 years, 1 month ago

Reviewers:
dsymonds

CC:
dsymonds, gobot, golang-dev

Visibility:
Public.

Patch Set 2 : diff -r 647f336edfe8 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 647f336edfe8 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 8e41e8e4a2ab https://go.googlecode.com/hg/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -21 lines)			Patch
	M	src/pkg/net/http/serve_test.go	View	1 2 3	8 chunks	+48 lines, -21 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 2 months ago (2013-05-20 03:23:25 UTC) #1

dsymonds

LGTM https://codereview.appspot.com/9570043/diff/5001/src/pkg/net/http/serve_test.go File src/pkg/net/http/serve_test.go (right): https://codereview.appspot.com/9570043/diff/5001/src/pkg/net/http/serve_test.go#newcode1730 src/pkg/net/http/serve_test.go:1730: req := []byte(strings.Replace(`GET / HTTP/1.1 why use strings.Replace? ...

12 years, 1 month ago (2013-05-22 01:33:29 UTC) #3

bradfitz

12 years, 1 month ago (2013-05-22 01:43:42 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=606b90b97f97 ***

net/http: add another Hijacker test

R=dsymonds
CC=gobot, golang-dev
https://codereview.appspot.com/9570043

https://codereview.appspot.com/9570043/diff/5001/src/pkg/net/http/serve_test.go
File src/pkg/net/http/serve_test.go (right):

https://codereview.appspot.com/9570043/diff/5001/src/pkg/net/http/serve_test....
src/pkg/net/http/serve_test.go:1730: req := []byte(strings.Replace(`GET /
HTTP/1.1
On 2013/05/22 01:33:29, dsymonds wrote:
> why use strings.Replace? It's a small string; just write the \r\n in the three
> places.

consistent with elsewhere.  but it's time to move it to a function.  Done.

Expand All Messages | Collapse All Messages