Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(751)

Issue 9569043: code review 9569043: runtime: change PollDesc.fd from int32 to uintptr (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by brainman
Modified:
9 years, 6 months ago
Reviewers:
dvyukov, bradfitz
CC:
golang-dev, bradfitz, mikio
Visibility:
Public.

Description

runtime: change PollDesc.fd from int32 to uintptr This is in preparation for netpoll windows version.

Patch Set 1 #

Patch Set 2 : diff -r fab6ba2a2d10 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r fab6ba2a2d10 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r fab6ba2a2d10 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M src/pkg/net/fd_poll_runtime.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/netpoll.goc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/runtime/netpoll_epoll.c View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/pkg/runtime/netpoll_kqueue.c View 1 4 chunks +5 lines, -5 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
brainman
Hello golang-dev@googlegroups.com (cc: dvyukov@google.com, mikioh.mikioh@gmail.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 6 months ago (2013-05-20 02:13:57 UTC) #1
brainman
I tested this on linux/386 only. It will affect amd64 and darwin, that I don't ...
9 years, 6 months ago (2013-05-20 02:16:32 UTC) #2
bradfitz
LGTM This is consistent with our portable representation of fds elsewhere. Tested on darmin/amd64. all.bash ...
9 years, 6 months ago (2013-05-20 02:49:11 UTC) #3
brainman
*** Submitted as https://code.google.com/p/go/source/detail?r=53b012eb5e17 *** runtime: change PollDesc.fd from int32 to uintptr This is in ...
9 years, 6 months ago (2013-05-20 02:55:59 UTC) #4
dvyukov
9 years, 6 months ago (2013-05-20 04:05:11 UTC) #5
Message was sent while issue was closed.
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b