Issue 95650043: Default Credential: Improve error messages for Compute Engine.

Issue 95650043: Default Credential: Improve error messages for Compute Engine. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by Anthony Moore

Modified:
12 years, 4 months ago

Reviewers:
beaton, Orest

CC:
wonderfly

Base URL:
https://code.google.com/p/google-api-java-client/

Visibility:
Public.

More Reviews

Description

Default Credential: Improve error messages for Compute Engine.

Patch Set 2 : Applied all comments. #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -24 lines)			Patch
M	google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProvider.java	View	1	3 chunks	+23 lines, -18 lines	0 comments	Download
M	google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/OAuth2Utils.java	View	1	2 chunks	+38 lines, -0 lines	0 comments	Download
M	google-api-client/src/test/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProviderTest.java	View	1	6 chunks	+38 lines, -4 lines	0 comments	Download
M	google-api-client/src/test/java/com/google/api/client/googleapis/compute/MockMetadataServerTransport.java	View		2 chunks	+29 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Orest

LGTM https://codereview.appspot.com/95650043/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProvider.java File google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProvider.java (right): https://codereview.appspot.com/95650043/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProvider.java#newcode243 google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProvider.java:243: Do we need the new line here? https://codereview.appspot.com/95650043/diff/1/google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/OAuth2Utils.java ...

12 years, 4 months ago (2014-05-28 21:54:00 UTC) #2

Anthony Moore

12 years, 4 months ago (2014-06-05 18:07:30 UTC) #4

Applied all comments.

https://codereview.appspot.com/95650043/diff/1/google-api-client/src/main/jav...
File
google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProvider.java
(right):

https://codereview.appspot.com/95650043/diff/1/google-api-client/src/main/jav...
google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProvider.java:243:

On 2014/05/28 21:54:00, Orest wrote:
> Do we need the new line here?

Done.

https://codereview.appspot.com/95650043/diff/1/google-api-client/src/main/jav...
File
google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/OAuth2Utils.java
(right):

https://codereview.appspot.com/95650043/diff/1/google-api-client/src/main/jav...
google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/OAuth2Utils.java:66:
catch (IOException exception) {
On 2014/05/28 21:54:00, Orest wrote:
> Please move this line at the end of the previous line.

Done.

https://codereview.appspot.com/95650043/diff/1/google-api-client/src/test/jav...
File
google-api-client/src/test/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProviderTest.java
(right):

https://codereview.appspot.com/95650043/diff/1/google-api-client/src/test/jav...
google-api-client/src/test/java/com/google/api/client/googleapis/auth/oauth2/DefaultCredentialProviderTest.java:132:
final String ACCESS_TOKEN =
"ya29.AHES6ZRN3-HlhAPya30GnW_bHSb_QtAS08i85nHq39HE3C2LTrCARA";
On 2014/05/28 21:54:00, Orest wrote:
> Maybe push ACCESS_TOKEN as a constant at the class level, since it is used in
so
> many places?

Done.

Expand All Messages | Collapse All Messages