code review 9557043: runtime: zeroize g->fnstart to not prevent GC of the closure

runtime: zeroize g->fnstart to not prevent GC of the closure
Fixes issue 5493.

[dvyukov, 2013-05-19 15:33:19]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[minux1, 2013-05-19 15:45:45]

LGTM.

Please rename bug5493.go to issue5493.go to be consistent
with other files in test/fixedbugs/.

[iant, 2013-05-20 00:44:02]

LGTM

Agree about renaming the test.

[dvyukov, 2013-05-20 04:17:06]

On 2013/05/19 15:45:45, minux wrote:
> LGTM.
> 
> Please rename bug5493.go to issue5493.go to be consistent
> with other files in test/fixedbugs/.

Done

[dvyukov, 2013-05-20 04:17:45]

*** Submitted as https://code.google.com/p/go/source/detail?r=2c128d417029 ***

runtime: zeroize g->fnstart to not prevent GC of the closure
Fixes issue 5493.

R=golang-dev, minux.ma, iant
CC=golang-dev
https://codereview.appspot.com/9557043

[dave_cheney.net, 2013-05-20 04:34:06]

This has broken some of the 386 builders. 

On 20/05/2013, at 14:17, dvyukov@google.com wrote:

> *** Submitted as
> https://code.google.com/p/go/source/detail?r=2c128d417029 ***
> 
> runtime: zeroize g->fnstart to not prevent GC of the closure
> Fixes issue 5493.
> 
> R=golang-dev, minux.ma, iant
> CC=golang-dev
> https://codereview.appspot.com/9557043
> 
> 
> https://codereview.appspot.com/9557043/
> 
> -- 
> 
> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
> 
> 

[dvyukov, 2013-05-20 06:57:51]

sent https://codereview.appspot.com/9573043

On Mon, May 20, 2013 at 8:33 AM, Dave Cheney <dave@cheney.net> wrote:
> This has broken some of the 386 builders.
>
> On 20/05/2013, at 14:17, dvyukov@google.com wrote:
>
>> *** Submitted as
>> https://code.google.com/p/go/source/detail?r=2c128d417029 ***
>>
>> runtime: zeroize g->fnstart to not prevent GC of the closure
>> Fixes issue 5493.
>>
>> R=golang-dev, minux.ma, iant
>> CC=golang-dev
>> https://codereview.appspot.com/9557043
>>
>>
>> https://codereview.appspot.com/9557043/
>>
>> --
>>
>> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>

[dave_cheney.net, 2013-05-20 06:59:08]

Thank you, I did not see that until just now and raised,
https://code.google.com/p/go/issues/detail?id=5516 please feel free to
close it, or mark 9573043 as fixing issue 5516.

On Mon, May 20, 2013 at 4:57 PM, Dmitry Vyukov <dvyukov@google.com> wrote:
> sent https://codereview.appspot.com/9573043
>
> On Mon, May 20, 2013 at 8:33 AM, Dave Cheney <dave@cheney.net> wrote:
>> This has broken some of the 386 builders.
>>
>> On 20/05/2013, at 14:17, dvyukov@google.com wrote:
>>
>>> *** Submitted as
>>> https://code.google.com/p/go/source/detail?r=2c128d417029 ***
>>>
>>> runtime: zeroize g->fnstart to not prevent GC of the closure
>>> Fixes issue 5493.
>>>
>>> R=golang-dev, minux.ma, iant
>>> CC=golang-dev
>>> https://codereview.appspot.com/9557043
>>>
>>>
>>> https://codereview.appspot.com/9557043/
>>>
>>> --
>>>
>>> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
>>> For more options, visit https://groups.google.com/groups/opt_out.
>>>
>>>

[dvyukov, 2013-05-20 07:05:44]

On 2013/05/20 06:59:08, dfc wrote:
> Thank you, I did not see that until just now and raised,
> https://code.google.com/p/go/issues/detail?id=5516 please feel free to
> close it, or mark 9573043 as fixing issue 5516.

Added "Fixes issue 5516".

> 
> On Mon, May 20, 2013 at 4:57 PM, Dmitry Vyukov <mailto:dvyukov@google.com>
wrote:
> > sent https://codereview.appspot.com/9573043
> >
> > On Mon, May 20, 2013 at 8:33 AM, Dave Cheney <mailto:dave@cheney.net> wrote:
> >> This has broken some of the 386 builders.
> >>
> >> On 20/05/2013, at 14:17, mailto:dvyukov@google.com wrote:
> >>
> >>> *** Submitted as
> >>> https://code.google.com/p/go/source/detail?r=2c128d417029 ***
> >>>
> >>> runtime: zeroize g->fnstart to not prevent GC of the closure
> >>> Fixes issue 5493.
> >>>
> >>> R=golang-dev, minux.ma, iant
> >>> CC=golang-dev
> >>> https://codereview.appspot.com/9557043
> >>>
> >>>
> >>> https://codereview.appspot.com/9557043/
> >>>
> >>> --
> >>>
> >>> ---You received this message because you are subscribed to the Google
Groups
> "golang-dev" group.
> >>> To unsubscribe from this group and stop receiving emails from it, send an
> email to mailto:golang-dev+unsubscribe@googlegroups.com.
> >>> For more options, visit https://groups.google.com/groups/opt_out.
> >>>
> >>>