Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(424)

Issue 95560046: code review 95560046: reflect: don't panic on delete from nil map. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 8 months ago by khr
Modified:
8 years, 8 months ago
Reviewers:
bradfitz
CC:
golang-codereviews, bradfitz
Visibility:
Public.

Description

reflect: don't panic on delete from nil map. Fixes issue 8051

Patch Set 1 #

Patch Set 2 : diff -r ddbcb0e26855 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r ddbcb0e26855 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r ddbcb0e26855 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 5 : diff -r eabf83a5e11c https://khr%40golang.org@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/pkg/reflect/all_test.go View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/runtime/hashmap.goc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
khr
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/
8 years, 8 months ago (2014-05-20 21:12:40 UTC) #1
bradfitz
LGTM I never knew that SetMapIndex with a zero value was defined as delete. Reminds ...
8 years, 8 months ago (2014-05-20 21:17:04 UTC) #2
khr
8 years, 8 months ago (2014-05-20 23:26:07 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=cd23c6e8c798 ***

reflect: don't panic on delete from nil map.

Fixes issue 8051

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/95560046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b