Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(131)

Issue 95550044: replicaset: clean up, extend timeout

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by axw
Modified:
5 years, 9 months ago
Reviewers:
mp+220378, wallyworld, fwereade
Visibility:
Public.

Description

replicaset: clean up, extend timeout Various cleanups, factoring out code, etc.; uncovered a bit of code that was leaking an *mgo.Session. I've extended the attempt strategy total for replset modifications to 2 minutes, since the mongo docs say that operations inducing a renegotiation of primary may incur downtime of >1m. I was able to reproduce the error initially on my machine by running the test in a loop; I have not reproduced it with these changes. Fixes lp:1321461 https://code.launchpad.net/~axwalk/juju-core/lp1321461-replicaset-failure/+merge/220378 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -192 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M replicaset/replicaset_test.go View 7 chunks +123 lines, -192 lines 0 comments Download

Messages

Total messages: 3
axw
Please take a look.
5 years, 9 months ago (2014-05-21 07:05:43 UTC) #1
wallyworld
LGTM
5 years, 9 months ago (2014-05-21 07:49:57 UTC) #2
fwereade
5 years, 9 months ago (2014-05-21 07:53:48 UTC) #3
This is awesome; LGTM. Yay for smaller functions :).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b