Hello golang-codereviews@googlegroups.com, I'd like you to review this change to http://go.googlecode.com/hg/
Until somebody grabs golang-example.org Why not just use https://github.com/golang/foo ? We at least 'own' that namespace. On Fri, May 16, 2014 at 4:49 AM, <mattn.jp@gmail.com> wrote: > Reviewers: golang-codereviews, > > Message: > Hello golang-codereviews@googlegroups.com, > > I'd like you to review this change to > http://go.googlecode.com/hg/ > > > Description: > cmd/go/doc: Fix example domain > code.org exists > > Please review this at https://codereview.appspot.com/95500043/ > > Affected files (+2, -2 lines): > M src/cmd/go/doc.go > > > Index: src/cmd/go/doc.go > =================================================================== > --- a/src/cmd/go/doc.go > +++ b/src/cmd/go/doc.go > @@ -706,10 +706,10 @@ > > If that page contains the meta tag > > - <meta name="go-import" content="example.org git > https://code.org/r/p/exproj"> > + <meta name="go-import" content="example.org git > https://golang-example.org/r/p/exproj"> > > the go tool will verify that https://example.org/?go-get=1 contains the > -same meta tag and then git clone https://code.org/r/p/exproj into > +same meta tag and then git clone https://golang-example.org/r/p/exprojinto > GOPATH/src/example.org. > > New downloaded packages are written to the first directory > > > -- > You received this message because you are subscribed to the Google Groups > "golang-codereviews" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-codereviews+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. >
Or https://code.example/ --- http://en.wikipedia.org/wiki/.example On Fri, May 16, 2014 at 10:34 AM, Brad Fitzpatrick <bradfitz@golang.org>wrote: > Until somebody grabs golang-example.org > > Why not just use https://github.com/golang/foo ? We at least 'own' that > namespace. > > > > > On Fri, May 16, 2014 at 4:49 AM, <mattn.jp@gmail.com> wrote: > >> Reviewers: golang-codereviews, >> >> Message: >> Hello golang-codereviews@googlegroups.com, >> >> I'd like you to review this change to >> http://go.googlecode.com/hg/ >> >> >> Description: >> cmd/go/doc: Fix example domain >> code.org exists >> >> Please review this at https://codereview.appspot.com/95500043/ >> >> Affected files (+2, -2 lines): >> M src/cmd/go/doc.go >> >> >> Index: src/cmd/go/doc.go >> =================================================================== >> --- a/src/cmd/go/doc.go >> +++ b/src/cmd/go/doc.go >> @@ -706,10 +706,10 @@ >> >> If that page contains the meta tag >> >> - <meta name="go-import" content="example.org git >> https://code.org/r/p/exproj"> >> + <meta name="go-import" content="example.org git >> https://golang-example.org/r/p/exproj"> >> >> the go tool will verify that https://example.org/?go-get=1 contains the >> -same meta tag and then git clone https://code.org/r/p/exproj into >> +same meta tag and then git clone https://golang-example.org/r/p/exprojinto >> GOPATH/src/example.org. >> >> New downloaded packages are written to the first directory >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "golang-codereviews" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to golang-codereviews+unsubscribe@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > >
Hello golang-codereviews@googlegroups.com, bradfitz@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
LGTM On May 18, 2014 7:18 AM, <mattn.jp@gmail.com> wrote: > Hello golang-codereviews@googlegroups.com, bradfitz@golang.org (cc: > golang-codereviews@googlegroups.com), > > Please take another look. > > > https://codereview.appspot.com/95500043/ >
*** Submitted as https://code.google.com/p/go/source/detail?r=9562b65a3c51 *** cmd/go/doc: Fix example domain code.org exists LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://codereview.appspot.com/95500043 Committer: Dave Cheney <dave@cheney.net>
