Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2002)

Issue 9545045: Support EC2_ env variables (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by wallyworld
Modified:
10 years, 11 months ago
Reviewers:
Danilo, jameinel, mp+164848
Visibility:
Public.

Description

Support EC2_ env variables Allow the user to specify their auth credentials using EC2_ style environment variables. I ran go fmt and it also made some changes. The tests failed to run due to a test http server not being closed when each test suite finished. I added a fix for this also, so now all tests pass when go test ./... is run from the project's root directory. https://code.launchpad.net/~wallyworld/goamz/ec2-env-credentials/+merge/164848 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Support EC2_ env variables #

Patch Set 3 : Support EC2_ env variables #

Patch Set 4 : Support EC2_ env variables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -5 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M aws/aws.go View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M aws/aws_test.go View 1 1 chunk +9 lines, -0 lines 0 comments Download
M ec2/ec2_test.go View 1 1 chunk +4 lines, -0 lines 0 comments Download
M exp/mturk/mturk_test.go View 1 1 chunk +4 lines, -0 lines 0 comments Download
M exp/sdb/sdb_test.go View 1 1 chunk +4 lines, -0 lines 0 comments Download
M exp/sns/sns_test.go View 1 1 chunk +4 lines, -0 lines 0 comments Download
M iam/iam_test.go View 1 2 chunks +6 lines, -2 lines 0 comments Download
M s3/s3_test.go View 1 1 chunk +1 line, -0 lines 0 comments Download
M testutil/http.go View 1 2 3 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 6
wallyworld
Please take a look.
10 years, 11 months ago (2013-05-21 07:20:30 UTC) #1
jameinel
LGTM
10 years, 11 months ago (2013-05-22 11:41:21 UTC) #2
Danilo
LGTM. It's weird to find a different approach to cleaning up the environment before the ...
10 years, 11 months ago (2013-05-22 11:56:52 UTC) #3
wallyworld
Please take a look.
10 years, 11 months ago (2013-05-23 02:57:47 UTC) #4
wallyworld
Please take a look.
10 years, 11 months ago (2013-05-23 03:14:56 UTC) #5
wallyworld
10 years, 11 months ago (2013-05-23 03:22:11 UTC) #6
*** Submitted:

Support EC2_ env variables

Allow the user to specify their auth credentials using EC2_ style
environment variables. I ran go fmt and it also made some changes.

The tests failed to run due to a test http server not being closed when
each test suite finished. I added a fix for this also, so now all tests
pass when go test ./... is run from the project's root directory.

R=jameinel, Danilo
CC=
https://codereview.appspot.com/9545045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b