Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(309)

Issue 95390043: code review 95390043: test: fix flakey test case for issue 4388 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 12 months ago by mikio
Modified:
10 years, 12 months ago
Reviewers:
gobot, rsc, dave
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

test: fix flakey test case for issue 4388 Seems like we need to drag the stack for <autogenerated>:1 on Plan 9. See http://build.golang.org/log/283b996102b833dd81c58301d78aceaa4fe9838b.

Patch Set 1 : diff -r 391d6d71c738 https://code.google.com/p/go #

Patch Set 2 : diff -r c6cb75c4736a https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M test/fixedbugs/issue4388.go View 1 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 5
mikio
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 12 months ago (2014-05-14 05:04:59 UTC) #1
rsc
LGTM
10 years, 12 months ago (2014-05-14 14:24:07 UTC) #2
mikio
*** Submitted as https://code.google.com/p/go/source/detail?r=e124fc87acd0 *** test: fix flakey test case for issue 4388 Seems like ...
10 years, 12 months ago (2014-05-14 21:39:24 UTC) #3
gobot
This CL appears to have broken the linux-arm-cheney-panda builder. See http://build.golang.org/log/af48fbb5a5d8c3c88a255349a81db0a500cedb42
10 years, 12 months ago (2014-05-14 22:04:59 UTC) #4
dave_cheney.net
10 years, 12 months ago (2014-05-14 22:17:58 UTC) #5
not really,

# GOMAXPROCS=2 runtime -cpu=1,2,4
--- FAIL: TestStackGrowth-4 (29.73 seconds)
stack_test.go:166: finalizer did not run
FAIL
FAIL runtime 236.294s

On Thu, May 15, 2014 at 8:04 AM,  <gobot@golang.org> wrote:
> This CL appears to have broken the linux-arm-cheney-panda builder.
> See http://build.golang.org/log/af48fbb5a5d8c3c88a255349a81db0a500cedb42
>
>
> https://codereview.appspot.com/95390043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b