Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(892)

Issue 9535044: code review 9535044: misc/dashboard: add go.tools to list of subrepos (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by dave
Modified:
12 years, 1 month ago
Reviewers:
CC:
r, adg, dsymonds, golang-dev
Visibility:
Public.

Description

misc/dashboard: add go.tools to list of subrepos

Patch Set 1 #

Patch Set 2 : diff -r 2a4b7b79c979 https://code.google.com/p/go #

Patch Set 3 : diff -r 2a4b7b79c979 https://code.google.com/p/go #

Patch Set 4 : diff -r 2a4b7b79c979 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M misc/dashboard/app/build/init.go View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7
dave_cheney.net
Hello r@golang.org, adg@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years, 1 month ago (2013-05-18 23:31:06 UTC) #1
dsymonds
LGTM
12 years, 1 month ago (2013-05-18 23:41:04 UTC) #2
dave_cheney.net
If I submit this, are you able to redeploy build.golang.org ? On Sun, May 19, ...
12 years, 1 month ago (2013-05-18 23:42:26 UTC) #3
dave_cheney.net
*** Submitted as https://code.google.com/p/go/source/detail?r=d8aeb43d6127 *** misc/dashboard: add go.tools to list of subrepos R=r, adg, dsymonds ...
12 years, 1 month ago (2013-05-19 00:04:40 UTC) #4
dsymonds
On Sat, May 18, 2013 at 4:42 PM, Dave Cheney <dave@cheney.net> wrote: > If I ...
12 years, 1 month ago (2013-05-19 00:28:08 UTC) #5
dsymonds
I've pushed it, and visited /init. I think that's it.
12 years, 1 month ago (2013-05-19 00:34:51 UTC) #6
dave_cheney.net
12 years, 1 month ago (2013-05-19 00:49:15 UTC) #7
Thanks, we'll see after the next commit. 

On 19/05/2013, at 10:34, David Symonds <dsymonds@golang.org> wrote:

> I've pushed it, and visited /init. I think that's it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b