https://codereview.appspot.com/9535043/diff/30001/google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineSubscriptionStore.java File google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineSubscriptionStore.java (right): https://codereview.appspot.com/9535043/diff/30001/google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineSubscriptionStore.java#newcode55 google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineSubscriptionStore.java:55: * {@link AppEngineDataStoreFactory.Builder#setDisableMemcache(boolean)} set to it's not enough, you ...
13 years, 3 months ago
(2013-06-25 14:20:44 UTC)
#2
https://codereview.appspot.com/9535043/diff/30001/google-api-client-appengine...
File
google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineSubscriptionStore.java
(right):
https://codereview.appspot.com/9535043/diff/30001/google-api-client-appengine...
google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineSubscriptionStore.java:55:
* {@link
AppEngineDataStoreFactory.Builder#setDisableMemcache(boolean)} set to
it's not enough, you should also call #build (of the builder) to get the
factory, and then call getDataStore.
So you should rephrase this comment
https://codereview.appspot.com/9535043/diff/30001/google-api-client-appengine...
File
google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/CachedAppEngineSubscriptionStore.java
(right):
https://codereview.appspot.com/9535043/diff/30001/google-api-client-appengine...
google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/CachedAppEngineSubscriptionStore.java:48:
* @deprecated (scheduled to be removed in 1.17) Use {@link
AppEngineDataStoreFactory} instead.
Why is this deprecated JavaDoc is different from the one in
AppEngineSubscriptionStore?
Can we just add the @Deprecated annotation without JavaDoc and we will inherit
the base deprecated JavaDoc (from the base class)?
https://codereview.appspot.com/9535043/diff/30001/google-api-client-appengine...
File
google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/package-info.java
(right):
https://codereview.appspot.com/9535043/diff/30001/google-api-client-appengine...
google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/package-info.java:21:
*
com.google.api.client.extensions.appengine.datastore.AppEngineDataStoreFactory}
instead.
you should add #getDataStore("notifications") or something similar, right?
Look at you comment on "JdoSubscriptionStore" - I think it's better
https://codereview.appspot.com/9535043/diff/30001/google-api-client/src/main/...
File
google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/NotificationHeaders.java
(right):
https://codereview.appspot.com/9535043/diff/30001/google-api-client/src/main/...
google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/NotificationHeaders.java:47:
* {@code
com.google.api.client.googleapis.extensions.servlet.notifications.WebhookHeaders.CHANNEL_ID}
CHANNEL_ID = X-Goog-Channel-ID. Is it the right the replacement of
X-Goog-Subscription-ID?
https://codereview.appspot.com/9535043/diff/30001/google-api-client/src/main/...
google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/NotificationHeaders.java:57:
* @deprecated (scheduled to be removed in 1.17) Use
ditto - X-Goog-Resource-ID
https://codereview.appspot.com/9535043/diff/30001/google-api-client/src/main/...
google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/NotificationHeaders.java:69:
* {@code
com.google.api.client.googleapis.extensions.servlet.notifications.WebhookHeaders.RESOURCE_URI}
ditto X-Goog-Resource-URI
https://codereview.appspot.com/9535043/diff/30001/google-api-client/src/main/...
google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/NotificationHeaders.java:79:
* {@code
com.google.api.client.googleapis.extensions.servlet.notifications.WebhookHeaders.RESOURCE_STATE}
ditto X-Goog-Resource-State
https://codereview.appspot.com/9535043/diff/30001/google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineSubscriptionStore.java File google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineSubscriptionStore.java (right): https://codereview.appspot.com/9535043/diff/30001/google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineSubscriptionStore.java#newcode55 google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineSubscriptionStore.java:55: * {@link AppEngineDataStoreFactory.Builder#setDisableMemcache(boolean)} set to On 2013/06/25 14:20:44, peleyal ...
13 years, 3 months ago
(2013-06-25 14:53:01 UTC)
#3
https://codereview.appspot.com/9535043/diff/30001/google-api-client-appengine...
File
google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineSubscriptionStore.java
(right):
https://codereview.appspot.com/9535043/diff/30001/google-api-client-appengine...
google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineSubscriptionStore.java:55:
* {@link
AppEngineDataStoreFactory.Builder#setDisableMemcache(boolean)} set to
On 2013/06/25 14:20:44, peleyal wrote:
> it's not enough, you should also call #build (of the builder) to get the
> factory, and then call getDataStore.
> So you should rephrase this comment
Done.
https://codereview.appspot.com/9535043/diff/30001/google-api-client-appengine...
File
google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/CachedAppEngineSubscriptionStore.java
(right):
https://codereview.appspot.com/9535043/diff/30001/google-api-client-appengine...
google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/CachedAppEngineSubscriptionStore.java:48:
* @deprecated (scheduled to be removed in 1.17) Use {@link
AppEngineDataStoreFactory} instead.
On 2013/06/25 14:20:44, peleyal wrote:
> Why is this deprecated JavaDoc is different from the one in
> AppEngineSubscriptionStore?
> Can we just add the @Deprecated annotation without JavaDoc and we will inherit
> the base deprecated JavaDoc (from the base class)?
Done.
https://codereview.appspot.com/9535043/diff/30001/google-api-client-appengine...
File
google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/package-info.java
(right):
https://codereview.appspot.com/9535043/diff/30001/google-api-client-appengine...
google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/package-info.java:21:
*
com.google.api.client.extensions.appengine.datastore.AppEngineDataStoreFactory}
instead.
On 2013/06/25 14:20:44, peleyal wrote:
> you should add #getDataStore("notifications") or something similar, right?
> Look at you comment on "JdoSubscriptionStore" - I think it's better
Done.
https://codereview.appspot.com/9535043/diff/30001/google-api-client/src/main/...
File
google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/NotificationHeaders.java
(right):
https://codereview.appspot.com/9535043/diff/30001/google-api-client/src/main/...
google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/NotificationHeaders.java:47:
* {@code
com.google.api.client.googleapis.extensions.servlet.notifications.WebhookHeaders.CHANNEL_ID}
On 2013/06/25 14:20:44, peleyal wrote:
> CHANNEL_ID = X-Goog-Channel-ID. Is it the right the replacement of
> X-Goog-Subscription-ID?
Yes.
https://codereview.appspot.com/9535043/diff/30001/google-api-client/src/main/...
google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/NotificationHeaders.java:57:
* @deprecated (scheduled to be removed in 1.17) Use
On 2013/06/25 14:20:44, peleyal wrote:
> ditto - X-Goog-Resource-ID
Yes.
https://codereview.appspot.com/9535043/diff/30001/google-api-client/src/main/...
google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/NotificationHeaders.java:69:
* {@code
com.google.api.client.googleapis.extensions.servlet.notifications.WebhookHeaders.RESOURCE_URI}
On 2013/06/25 14:20:44, peleyal wrote:
> ditto X-Goog-Resource-URI
Yes.
https://codereview.appspot.com/9535043/diff/30001/google-api-client/src/main/...
google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/NotificationHeaders.java:79:
* {@code
com.google.api.client.googleapis.extensions.servlet.notifications.WebhookHeaders.RESOURCE_STATE}
On 2013/06/25 14:20:44, peleyal wrote:
> ditto X-Goog-Resource-State
Done.
https://codereview.appspot.com/9535043/diff/30001/google-api-client/src/main/...
google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/NotificationHeaders.java:79:
* {@code
com.google.api.client.googleapis.extensions.servlet.notifications.WebhookHeaders.RESOURCE_STATE}
On 2013/06/25 14:20:44, peleyal wrote:
> ditto X-Goog-Resource-State
Yes.
Issue 9535043: api: deprecate com.google.api.client.googleapis.subscriptions
(Closed)
Created 13 years, 5 months ago by yanivi
Modified 13 years, 3 months ago
Reviewers: peleyal
Base URL: https://code.google.com/p/google-api-java-client/
Comments: 15
