Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1845)

Issue 95320043: code review 95320043: net: fix documentation for SetLinger (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by mikio
Modified:
6 years, 9 months ago
Reviewers:
gobot, iant
CC:
golang-codereviews, iant
Visibility:
Public.

Description

net: fix documentation for SetLinger Fixes issue 7974.

Patch Set 1 #

Patch Set 2 : diff -r 5283a606b755 https://code.google.com/p/go #

Patch Set 3 : diff -r 5283a606b755 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 8a13066e4922 https://code.google.com/p/go #

Patch Set 5 : diff -r 9dda71feeba5 https://code.google.com/p/go #

Patch Set 6 : diff -r 6e10ddc0bbc2 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M src/pkg/net/tcpsock_plan9.go View 1 2 3 4 1 chunk +8 lines, -7 lines 0 comments Download
M src/pkg/net/tcpsock_posix.go View 1 2 3 4 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 12
mikio
Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
6 years, 9 months ago (2014-05-12 17:18:06 UTC) #1
iant
https://codereview.appspot.com/95320043/diff/40001/src/pkg/net/tcpsock_posix.go File src/pkg/net/tcpsock_posix.go (right): https://codereview.appspot.com/95320043/diff/40001/src/pkg/net/tcpsock_posix.go#newcode102 src/pkg/net/tcpsock_posix.go:102: // If sec > 0, Close returns immediately and ...
6 years, 9 months ago (2014-05-12 17:59:43 UTC) #2
mikio
On Tue, May 13, 2014 at 2:59 AM, <iant@golang.org> wrote: > I think that both ...
6 years, 9 months ago (2014-05-13 03:34:42 UTC) #3
iant
On Mon, May 12, 2014 at 8:34 PM, Mikio Hara <mikioh.mikioh@gmail.com> wrote: > On Tue, ...
6 years, 9 months ago (2014-05-13 05:07:47 UTC) #4
mikio
On Tue, May 13, 2014 at 2:07 PM, Ian Lance Taylor <iant@golang.org> wrote: > I ...
6 years, 9 months ago (2014-05-13 05:23:30 UTC) #5
iant
On Mon, May 12, 2014 at 10:23 PM, Mikio Hara <mikioh.mikioh@gmail.com> wrote: > On Tue, ...
6 years, 9 months ago (2014-05-13 05:55:37 UTC) #6
mikio
much better, thanks. On Tue, May 13, 2014 at 2:55 PM, Ian Lance Taylor <iant@golang.org> ...
6 years, 9 months ago (2014-05-13 06:17:09 UTC) #7
mikio
Hello golang-codereviews@googlegroups.com, iant@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
6 years, 9 months ago (2014-05-13 06:19:11 UTC) #8
iant
LGTM
6 years, 9 months ago (2014-05-13 17:02:34 UTC) #9
mikio
*** Submitted as https://code.google.com/p/go/source/detail?r=391d6d71c738 *** net: fix documentation for SetLinger Fixes issue 7974. LGTM=iant R=golang-codereviews, ...
6 years, 9 months ago (2014-05-14 03:12:06 UTC) #10
gobot
This CL appears to have broken the plan9-386-cnielsen builder. See http://build.golang.org/log/283b996102b833dd81c58301d78aceaa4fe9838b
6 years, 9 months ago (2014-05-14 03:39:25 UTC) #11
mikio
6 years, 9 months ago (2014-05-14 04:12:47 UTC) #12
looks lile i parked a wrong spot. in this case skip=4 is not good for plan9.

On Wednesday, May 14, 2014 12:39:25 PM UTC+9, go...@golang.org wrote:
>
> This CL appears to have broken the plan9-386-cnielsen builder. 
> See http://build.golang.org/log/283b996102b833dd81c58301d78aceaa4fe9838b 
>
> https://codereview.appspot.com/95320043/ 
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b