Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(893)

Issue 95130043: code review 95130043: database/sql: fix accounting of open connections (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by bradfitz
Modified:
6 years, 8 months ago
Reviewers:
gobot, iant
CC:
golang-codereviews, iant
Visibility:
Public.

Description

database/sql: fix accounting of open connections Existing test TestMaxOpenConns was failing occasionally, especially with higher values of GOMAXPROCS. Fixes Issue 7532

Patch Set 1 #

Patch Set 2 : diff -r cecde18b76e0 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r cecde18b76e0 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 1ce8d70162aa https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/pkg/database/sql/sql.go View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4
bradfitz
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
6 years, 8 months ago (2014-05-07 18:44:54 UTC) #1
iant
LGTM
6 years, 8 months ago (2014-05-07 18:47:00 UTC) #2
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=a6cb2adc55eb *** database/sql: fix accounting of open connections Existing test TestMaxOpenConns was ...
6 years, 8 months ago (2014-05-07 18:54:32 UTC) #3
gobot
6 years, 8 months ago (2014-05-08 03:14:49 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the freebsd-arm-cheney builder.
See http://build.golang.org/log/95ffbc41ea1dad2f50c627fdd5965df9aabe4266
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b