code review 9509045: go.tools/cmd/vet: use "go test" to test

go.tools/cmd/vet: use "go test" to test
- remove Makefile
- move test data into a subdirectory
- encapsulate the invocation of errchk into a standard Test using os.exec

[r, 2013-05-20 21:28:55]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.tools

[minux1, 2013-05-20 21:46:00]

Hi Rob, do you think it's worthwhile to enhance test/run.go to support
invoke cmd/vet for its errorcheck action?
Then we don't need to use the perl script (test/errchk) anymore.

[r, 2013-05-20 22:59:04]

That would be fine with me.

-rob

[r, 2013-05-20 22:59:55]

Hold on. I misread what you were saying. What do you mean by running
vet to get errorcheck?

-rob

[minux1, 2013-05-20 23:22:11]

On Tuesday, May 21, 2013, Rob Pike wrote:

> Hold on. I misread what you were saying. What do you mean by running
> vet to get errorcheck?
>
i mean we reuse test/run.go to test cmd/vet.
the errorcheck action of test/run,go only support invoking the gc compiler,
we can enhance it to invoke arbitrary program.

[r, 2013-05-20 23:52:47]

not sure how that helps here. run.go isn't compiled and installed, so
i'd need to build that as well as vet. moreover, i'd still need the
TestVet function pretty much as it is now.

[minux1, 2013-05-21 12:36:21]

On Tue, May 21, 2013 at 7:52 AM, Rob Pike <r@golang.org> wrote:

> not sure how that helps here. run.go isn't compiled and installed, so
> i'd need to build that as well as vet. moreover, i'd still need the
> TestVet function pretty much as it is now.
>
yes. but errchk script relies on /usr/bin/perl, but it doesn't exist on
windows
and NetBSD (usually /usr/pkg/bin/perl). we could use "#!/usr/bin/env perl"
shebang line to solve the latter problem.

my proposal is to reuse the errorcheck functionality of  test/run.go in the
last step.

[rsc, 2013-05-22 17:14:15]

LGTM

Just use t.Skip when runtime.GOOS=="windows" and we can move on.

Russ

[r, 2013-05-22 17:20:54]

*** Submitted as
https://code.google.com/p/go/source/detail?r=a4800ca823b1&repo=tools ***

go.tools/cmd/vet: use "go test" to test
- remove Makefile
- move test data into a subdirectory
- encapsulate the invocation of errchk into a standard Test using os.exec

R=golang-dev, minux.ma, rsc
CC=golang-dev
https://codereview.appspot.com/9509045