code review 95090044: cmd/objdump: works with windows pe executables now

cmd/objdump: works with windows pe executables now

Most code is copy from addr2line change 01dd67e5827f

Update issue 7406
Fixes issue 7937

[brainman, 2014-05-08 04:35:15]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[brainman, 2014-05-08 04:37:19]

New test is disabled for plan9. I expect it will fail like it did at
01dd67e5827f.

Alex

[iant, 2014-05-09 20:11:55]

https://codereview.appspot.com/95090044/diff/40001/src/cmd/objdump/objdump_te...
File src/cmd/objdump/objdump_test.go (right):

https://codereview.appspot.com/95090044/diff/40001/src/cmd/objdump/objdump_te...
src/cmd/objdump/objdump_test.go:105: if srcLineNo != "75" {
Put a comment on line 75 saying something like

// This is line 75.  The test depends on that.

[brainman, 2014-05-10 11:00:46]

Hello golang-codereviews@googlegroups.com, iant@golang.org (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[brainman, 2014-05-10 11:01:23]

PTAL

Alex

https://codereview.appspot.com/95090044/diff/40001/src/cmd/objdump/objdump_te...
File src/cmd/objdump/objdump_test.go (right):

https://codereview.appspot.com/95090044/diff/40001/src/cmd/objdump/objdump_te...
src/cmd/objdump/objdump_test.go:105: if srcLineNo != "75" {
On 2014/05/09 20:11:55, iant wrote:
> Put a comment on line 75 saying something like
> 
> // This is line 75.  The test depends on that.

Done.

[0intro, 2014-05-11 20:22:44]

> New test is disabled for plan9. I expect it will fail like it did at
> 01dd67e5827f.

Thanks. I'll have to implement parsing of pclntab and symtab on Plan 9 for Go
1.4.

[iant, 2014-05-12 04:58:37]

LGTM

[brainman, 2014-05-12 07:01:04]

*** Submitted as https://code.google.com/p/go/source/detail?r=5fdfef4f39f6 ***

cmd/objdump: works with windows pe executables now

Most code is copy from addr2line change 01dd67e5827f

Update issue 7406
Fixes issue 7937

LGTM=iant
R=golang-codereviews, iant, 0intro
CC=golang-codereviews
https://codereview.appspot.com/95090044

[gobot, 2014-05-12 08:23:47]

This CL appears to have broken the plan9-386-cnielsen builder.
See http://build.golang.org/log/f91d7e1e76ee026c417379eb3960879794f48bd4

[0intro, 2014-05-12 09:16:43]

> This CL appears to have broken the plan9-386-cnielsen builder.
> See http://build.golang.org/log/f91d7e1e76ee026c417379eb3960879794f48bd4

Don't worry. It's the usual failure in the gc test suite.