Issue 95010048: code review 95010048: acme: fix two flush bugs in new log file

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 95010048: code review 95010048: acme: fix two flush bugs in new log file (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by rsc

Modified:
10 years, 8 months ago

Reviewers:

CC:
rsc

Visibility:
Public.

Description

acme: fix two flush bugs in new log file

Patch Set 1 #

Patch Set 2 : diff -r 9e531f5eb3ab https://code.google.com/p/plan9port #

Patch Set 3 : diff -r 9e531f5eb3ab https://code.google.com/p/plan9port #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	src/cmd/acme/logf.c	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello rsc, I'd like you to review this change to https://code.google.com/p/plan9port

10 years, 8 months ago (2014-05-06 02:27:58 UTC) #1

rsc

10 years, 8 months ago (2014-05-06 02:28:05 UTC) #2

*** Submitted as
https://code.google.com/p/plan9port/source/detail?r=9bfe12150c5e ***

acme: fix two flush bugs in new log file

TBR=rsc
https://codereview.appspot.com/95010048

Expand All Messages | Collapse All Messages