Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(491)

Issue 95010046: code review 95010046: go1.2.2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by adg
Modified:
8 years, 6 months ago
Reviewers:
gobot, dfc, dvyukov, bradfitz
CC:
rsc, bradfitz, golang-codereviews, golang-dev
Visibility:
Public.

Description

go1.2.2

Patch Set 1 #

Patch Set 2 : diff -r 548a4e6eeabb https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M VERSION View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10
adg
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
8 years, 7 months ago (2014-05-05 16:04:22 UTC) #1
adg
There are no changes in the main repository for this point release. Bumping the version ...
8 years, 7 months ago (2014-05-05 16:06:31 UTC) #2
gobot
Replacing golang-dev with golang-codereviews. To the author of this CL: If you are using 'hg ...
8 years, 7 months ago (2014-05-05 16:07:22 UTC) #3
bradfitz
LGTM I guess. Sad to have to do a point release for something so boring.
8 years, 7 months ago (2014-05-05 16:50:59 UTC) #4
adg
On 5 May 2014 09:50, <bradfitz@golang.org> wrote: > Sad to have to do a point ...
8 years, 7 months ago (2014-05-05 16:53:39 UTC) #5
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=9c4fdd8369ca *** go1.2.2 R=rsc, bradfitz CC=golang-codereviews, golang-dev https://codereview.appspot.com/95010046
8 years, 7 months ago (2014-05-05 17:43:41 UTC) #6
gobot
This CL appears to have broken the linux-amd64 builder. See http://build.golang.org/log/04a7ef4512491a31b1273e1790d7b57b4767f82f
8 years, 6 months ago (2014-05-27 00:55:14 UTC) #7
dfc
um, what ? http://build.golang.org/log/04a7ef4512491a31b1273e1790d7b57b4767f82f says there is no entity On Tue, May 27, 2014 at ...
8 years, 6 months ago (2014-05-27 01:07:53 UTC) #8
adg
On 27 May 2014 11:07, Dave Cheney <dave@cheney.net> wrote: > um, what ? > http://build.golang.org/log/04a7ef4512491a31b1273e1790d7b57b4767f82f ...
8 years, 6 months ago (2014-05-27 02:03:25 UTC) #9
dvyukov
8 years, 6 months ago (2014-05-27 07:33:44 UTC) #10
On Tue, May 27, 2014 at 6:02 AM, Andrew Gerrand <adg@golang.org> wrote:
>
> On 27 May 2014 11:07, Dave Cheney <dave@cheney.net> wrote:
>>
>> um, what ?
>> http://build.golang.org/log/04a7ef4512491a31b1273e1790d7b57b4767f82f
>> says there is no entity
>
>
> That's weird.


I suspect that they are coming from goperfd.appspot.com.
When I've merged my lagged codebase with go.tools tip, it switched
from sending emails to my address to contacting go-dev app.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b