code review 9495045: misc/dashboard/builder: handle Plan 9 in defaultSuffix()

misc/dashboard/builder: handle Plan 9 in defaultSuffix()

[minux1, 2013-05-20 17:47:43]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-05-20 17:50:20]

LGTM



On Mon, May 20, 2013 at 10:47 AM, <minux.ma@gmail.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> misc/dashboard/builder: handle Plan 9 in defaultSuffix()
>
> Please review this at
https://codereview.appspot.**com/9495045/<https://codereview.appspot.com/9495...
>
> Affected files:
>   M misc/dashboard/builder/main.go
>
>
> Index: misc/dashboard/builder/main.go
> ==============================**==============================**=======
> --- a/misc/dashboard/builder/main.**go
> +++ b/misc/dashboard/builder/main.**go
> @@ -608,10 +608,14 @@
>  // defaultSuffix returns file extension used for command files in
>  // current os environment.
>  func defaultSuffix() string {
> -       if runtime.GOOS == "windows" {
> +       switch runtime.GOOS {
> +       case "windows":
>                 return ".bat"
> +       case "plan9":
> +               return ".rc"
> +       default:
> +               return ".bash"
>         }
> -       return ".bash"
>  }
>
>  // defaultBuildRoot returns default buildroot directory.
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[minux1, 2013-05-20 19:23:05]

*** Submitted as https://code.google.com/p/go/source/detail?r=c786b0f8eb4b ***

misc/dashboard/builder: handle Plan 9 in defaultSuffix()

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/9495045