fix comments and send it again. https://codereview.appspot.com/94740043/diff/1/spfaq/AndroidManifest.xml File spfaq/AndroidManifest.xml (right): https://codereview.appspot.com/94740043/diff/1/spfaq/AndroidManifest.xml#newc... spfaq/AndroidManifest.xml:28: android:name="app.shoppoke.faq.storedetail.MainScreenActivity" move it into package "app.shoppoke.faq.landing" https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... File spfaq/src/app/shoppoke/faq/receiver/DateAndTimeHelper.java (right): https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/DateAndTimeHelper.java:10: public String getDateAndTime() { move it into UiUtilities and make it static method. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... File spfaq/src/app/shoppoke/faq/receiver/NotificationHelper.java (right): https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/NotificationHelper.java:21: private String shortCode; change it to shortCodeOrNumber https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/NotificationHelper.java:29: public NotificationHelper(Context context, StoreResponseObject sro, Use only one constructor and pass message as null. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/NotificationHelper.java:35: private void saveDetails(Context context, StoreResponseObject sro, move savedetails assignment in the constructor. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/NotificationHelper.java:43: public void buildNotification() { Change buildNotification to saveAndBuildNotification https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/NotificationHelper.java:51: StoreSmsPhoneCallObjectModel spc = new StoreSmsPhoneCallObjectModel(); remove these 2 lines. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/NotificationHelper.java:77: StoreSmsPhoneCallObjectModel storeSMS; remove storeSMS member variable. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/NotificationHelper.java:80: storeSMS = new StoreSmsPhoneCallObjectModel(shortCode, sro.storeId, context); use only one constructor, and pass type from outside. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... File spfaq/src/app/shoppoke/faq/receiver/SmsReceiver.java (right): https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/SmsReceiver.java:19: String message = null; change message to messageBody. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... File spfaq/src/app/shoppoke/faq/receiver/SmsReceiverHandler.java (right): https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/SmsReceiverHandler.java:37: item, message, shortCode, RECEIVER_TYPE.SMS); dont overload notificationhelper. just create one object and save it here only. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... File spfaq/src/app/shoppoke/faq/receiver/StoreSmsPhoneCallObjectModel.java (right): https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/StoreSmsPhoneCallObjectModel.java:25: String rType; make all them private. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/StoreSmsPhoneCallObjectModel.java:117: public List<StoreSmsPhoneCallObjectModel> fetchCallData(Context context, remove this method. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/StoreSmsPhoneCallObjectModel.java:135: public static List<StoreSmsPhoneCallObjectModel> getSms(Context activity, remove these 2 methods. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/StoreSmsPhoneCallObjectModel.java:136: int storeId) { remove these 2 methods. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/sto... File spfaq/src/app/shoppoke/faq/storedetail/MainScreenActivity.java (right): https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/sto... spfaq/src/app/shoppoke/faq/storedetail/MainScreenActivity.java:17: private String[] flash_screen_messages; flash_screen_messages camelcase it. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/sto... spfaq/src/app/shoppoke/faq/storedetail/MainScreenActivity.java:19: private ViewPagerAdapter viewPagerAdapter; viewPagerAdapte, declare it inside. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/sto... spfaq/src/app/shoppoke/faq/storedetail/MainScreenActivity.java:20: private Button startExplore; startExplore => startExploreButton https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/sto... spfaq/src/app/shoppoke/faq/storedetail/MainScreenActivity.java:32: getActionBar().hide(); dont hide getactionbar
https://codereview.appspot.com/94740043/diff/1/spfaq/AndroidManifest.xml File spfaq/AndroidManifest.xml (right): https://codereview.appspot.com/94740043/diff/1/spfaq/AndroidManifest.xml#newc... spfaq/AndroidManifest.xml:28: android:name="app.shoppoke.faq.storedetail.MainScreenActivity" On 2014/04/24 11:43:29, mail2coolgarg wrote: > move it into package "app.shoppoke.faq.landing" Done. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... File spfaq/src/app/shoppoke/faq/receiver/NotificationHelper.java (right): https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/NotificationHelper.java:21: private String shortCode; On 2014/04/24 11:43:29, mail2coolgarg wrote: > change it to shortCodeOrNumber Done. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/NotificationHelper.java:29: public NotificationHelper(Context context, StoreResponseObject sro, On 2014/04/24 11:43:29, mail2coolgarg wrote: > Use only one constructor and pass message as null. Done. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/NotificationHelper.java:35: private void saveDetails(Context context, StoreResponseObject sro, On 2014/04/24 11:43:29, mail2coolgarg wrote: > move savedetails assignment in the constructor. Done. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/NotificationHelper.java:51: StoreSmsPhoneCallObjectModel spc = new StoreSmsPhoneCallObjectModel(); On 2014/04/24 11:43:29, mail2coolgarg wrote: > remove these 2 lines. Done. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/NotificationHelper.java:77: StoreSmsPhoneCallObjectModel storeSMS; On 2014/04/24 11:43:29, mail2coolgarg wrote: > remove storeSMS member variable. Done. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/NotificationHelper.java:80: storeSMS = new StoreSmsPhoneCallObjectModel(shortCode, sro.storeId, context); On 2014/04/24 11:43:29, mail2coolgarg wrote: > use only one constructor, and pass type from outside. Done. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... File spfaq/src/app/shoppoke/faq/receiver/SmsReceiver.java (right): https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/rec... spfaq/src/app/shoppoke/faq/receiver/SmsReceiver.java:19: String message = null; On 2014/04/24 11:43:29, mail2coolgarg wrote: > change message to messageBody. Done. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/sto... File spfaq/src/app/shoppoke/faq/storedetail/MainScreenActivity.java (right): https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/sto... spfaq/src/app/shoppoke/faq/storedetail/MainScreenActivity.java:17: private String[] flash_screen_messages; On 2014/04/24 11:43:29, mail2coolgarg wrote: > flash_screen_messages camelcase it. Done. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/sto... spfaq/src/app/shoppoke/faq/storedetail/MainScreenActivity.java:19: private ViewPagerAdapter viewPagerAdapter; On 2014/04/24 11:43:29, mail2coolgarg wrote: > viewPagerAdapte, declare it inside. Done. https://codereview.appspot.com/94740043/diff/1/spfaq/src/app/shoppoke/faq/sto... spfaq/src/app/shoppoke/faq/storedetail/MainScreenActivity.java:20: private Button startExplore; On 2014/04/24 11:43:29, mail2coolgarg wrote: > startExplore => startExploreButton Done.
commit.
