Issue 9464043: Support juju-gui-source=branch:revno

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9464043: Support juju-gui-source=branch:revno

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by frankban

Modified:
10 years, 11 months ago

Reviewers:
bac, mp+164326, jeff.pihach

Visibility:
Public.

Description

Support juju-gui-source=branch:revno Added support for creating and deploying a release from a specific branch revision. https://code.launchpad.net/~frankban/charms/precise/juju-gui/revision-support/+merge/164326 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Support juju-gui-source=branch:revno #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -8 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	config.yaml	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	hooks/utils.py	View	5 chunks	+26 lines, -5 lines	0 comments	Download
M	revision	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/test_utils.py	View	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bac

LGTM where G=great. Thanks Frankban. https://codereview.appspot.com/9464043/diff/1/hooks/utils.py File hooks/utils.py (right): https://codereview.appspot.com/9464043/diff/1/hooks/utils.py#newcode220 hooks/utils.py:220: """, re.VERBOSE) If only ...

10 years, 11 months ago (2013-05-17 13:26:38 UTC) #2

frankban

*** Submitted: Support juju-gui-source=branch:revno Added support for creating and deploying a release from a specific ...

10 years, 11 months ago (2013-05-17 15:04:30 UTC) #4

Thanks for the reviews Brad and Jeff!

Expand All Messages | Collapse All Messages