Add another status icon for IME mode.

Show property icons by engine on panel.

[fujiwara, 2013-05-21 15:54:17]

Probably I think adding another icon for IME input mode would be the solution to
keep the IME icon and follow MS-IME.

[Peng, 2013-05-23 03:53:45]

On 2013/05/21 15:54:17, fujiwara wrote:
> Probably I think adding another icon for IME input mode would be the solution
to
> keep the IME icon and follow MS-IME.

Is this really necessary? As I know some IMEs may have more mode properties. Why
only InputMode property is more important than other properties, and only
display it on StatusBar?

So I think it is better to just show one ime icon on StatusBar. And if user
really want to see all properties, we could re-implement a floating panel to
show all properties as we did before.

[fujiwara, 2013-08-01 01:37:16]

On 2013/05/23 03:53:45, Peng wrote:
> On 2013/05/21 15:54:17, fujiwara wrote:
> > Probably I think adding another icon for IME input mode would be the
solution
> to
> > keep the IME icon and follow MS-IME.
> 
> Is this really necessary? As I know some IMEs may have more mode properties.
Why
> only InputMode property is more important than other properties, and only
> display it on StatusBar?
> 
> So I think it is better to just show one ime icon on StatusBar. And if user
> really want to see all properties, we could re-implement a floating panel to
> show all properties as we did before.

I added ibus_engine_set_icon_property_key to show a property on the status icon.
I think it's good for engines to provide a way to change the icon since gtk
status icon shows one icon only.

When an engine try to show another status icon, there is no way to know if
ibus-ui-gtk3 is launcehd.

I also thought to draw multiple icons on one gtk status icon but gtk status icon
uses a private API to resize the icon.

[fujiwara, 2013-09-05 03:55:32]

On 2013/08/01 01:37:16, fujiwara wrote:
> On 2013/05/23 03:53:45, Peng wrote:
> > On 2013/05/21 15:54:17, fujiwara wrote:
> > > Probably I think adding another icon for IME input mode would be the
> solution
> > to
> > > keep the IME icon and follow MS-IME.
> > 
> > Is this really necessary? As I know some IMEs may have more mode properties.
> Why
> > only InputMode property is more important than other properties, and only
> > display it on StatusBar?
> > 
> > So I think it is better to just show one ime icon on StatusBar. And if user
> > really want to see all properties, we could re-implement a floating panel to
> > show all properties as we did before.
> 
> I added ibus_engine_set_icon_property_key to show a property on the status
icon.
> I think it's good for engines to provide a way to change the icon since gtk
> status icon shows one icon only.
> 
> When an engine try to show another status icon, there is no way to know if
> ibus-ui-gtk3 is launcehd.
> 
> I also thought to draw multiple icons on one gtk status icon but gtk status
icon
> uses a private API to resize the icon.

I added to show all property icons by engine if IBusProperty has symbol.

[Peng, 2013-09-06 02:42:09]

https://codereview.appspot.com/9462047/diff/11001/ui/gtk3/property.vala
File ui/gtk3/property.vala (right):

https://codereview.appspot.com/9462047/diff/11001/ui/gtk3/property.vala#newco...
ui/gtk3/property.vala:23: class IconProperty : IBus.Property {
could you please add some comment about this class? I don't understand what's
the class for.

https://codereview.appspot.com/9462047/diff/11001/ui/gtk3/property.vala#newco...
ui/gtk3/property.vala:31: if (show) {
what's the meaning of show?

[Peng, 2013-09-06 02:42:56]

On 2013/09/06 02:42:09, Peng wrote:
> https://codereview.appspot.com/9462047/diff/11001/ui/gtk3/property.vala
> File ui/gtk3/property.vala (right):
> 
>
https://codereview.appspot.com/9462047/diff/11001/ui/gtk3/property.vala#newco...
> ui/gtk3/property.vala:23: class IconProperty : IBus.Property {
> could you please add some comment about this class? I don't understand what's
> the class for.
> 
>
https://codereview.appspot.com/9462047/diff/11001/ui/gtk3/property.vala#newco...
> ui/gtk3/property.vala:31: if (show) {
> what's the meaning of show?

look's like the behavior of this cl has been changed. update the description of
this CL?

[fujiwara, 2013-09-06 08:44:54]

I also changed "-" to U+2013:
https://wiki.gnome.org/GnomeGoals/UnicodeUsage

https://codereview.appspot.com/9462047/diff/11001/ui/gtk3/property.vala
File ui/gtk3/property.vala (right):

https://codereview.appspot.com/9462047/diff/11001/ui/gtk3/property.vala#newco...
ui/gtk3/property.vala:23: class IconProperty : IBus.Property {
On 2013/09/06 02:42:09, Peng wrote:
> could you please add some comment about this class? I don't understand what's
> the class for.

I added the comment.
The class IconProperty is the top level IBusProperty and it includes
GtkStatusIcon.

https://codereview.appspot.com/9462047/diff/11001/ui/gtk3/property.vala#newco...
ui/gtk3/property.vala:31: if (show) {
On 2013/09/06 02:42:09, Peng wrote:
> what's the meaning of show?

The show boolean is decided by the gsettings value with ibus-setup.
If the show is true, show_icon() is called and GtkStatusIcon shows the icon if
IBusProperty.symbol has any chars.
In most engines, IBusProperty.symbol is "" so the null icon does not have to be
shown.
Now I renamed "show" to "setting_show".

[fujiwara, 2013-09-06 08:47:25]

On 2013/09/06 02:42:56, Peng wrote:
> On 2013/09/06 02:42:09, Peng wrote:
> > https://codereview.appspot.com/9462047/diff/11001/ui/gtk3/property.vala
> > File ui/gtk3/property.vala (right):
> > 
> >
>
https://codereview.appspot.com/9462047/diff/11001/ui/gtk3/property.vala#newco...
> > ui/gtk3/property.vala:23: class IconProperty : IBus.Property {
> > could you please add some comment about this class? I don't understand
what's
> > the class for.
> > 
> >
>
https://codereview.appspot.com/9462047/diff/11001/ui/gtk3/property.vala#newco...
> > ui/gtk3/property.vala:31: if (show) {
> > what's the meaning of show?
> 
> look's like the behavior of this cl has been changed. update the description
of
> this CL?

Yes, the description also has been changed.
But I don't change the CL subject as I think to follow the email subject.

[Peng, 2013-09-09 14:40:51]

https://codereview.appspot.com/9462047/diff/18001/ui/gtk3/property.vala
File ui/gtk3/property.vala (right):

https://codereview.appspot.com/9462047/diff/18001/ui/gtk3/property.vala#newco...
ui/gtk3/property.vala:38: show_icon();
Still not very clear for me. Why setting_show is true, you call show_icon(), but
when it is false, you call m_property_icon.set_visible(false). It is not
consistent

[Peng, 2013-09-09 20:16:01]

On 2013/09/09 14:40:51, Peng wrote:
> https://codereview.appspot.com/9462047/diff/18001/ui/gtk3/property.vala
> File ui/gtk3/property.vala (right):
> 
>
https://codereview.appspot.com/9462047/diff/18001/ui/gtk3/property.vala#newco...
> ui/gtk3/property.vala:38: show_icon();
> Still not very clear for me. Why setting_show is true, you call show_icon(),
but
> when it is false, you call m_property_icon.set_visible(false). It is not
> consistent

BTW, I am still have a lot of concern about this change. It will pollute users'
systray. I guess users will not happy with it. :(

[fujiwara, 2013-09-10 09:26:52]

I updated the patch so that all property icons are shown.
Also menu items are moved into property icons.

I also thought gnome-applet but it's need to be implemented per the desktop
panel library and gnome-panel is no longer available in Fedora. So I think
gnome-applet is not an option now.

https://codereview.appspot.com/9462047/diff/18001/ui/gtk3/property.vala
File ui/gtk3/property.vala (right):

https://codereview.appspot.com/9462047/diff/18001/ui/gtk3/property.vala#newco...
ui/gtk3/property.vala:38: show_icon();
On 2013/09/09 14:40:51, Peng wrote:
> Still not very clear for me. Why setting_show is true, you call show_icon(),
but
> when it is false, you call m_property_icon.set_visible(false). It is not
> consistent 

Done.

[fujiwara, 2013-09-11 14:32:25]

On 2013/09/10 09:26:52, fujiwara wrote:
> I updated the patch so that all property icons are shown.
> Also menu items are moved into property icons.
> 
> I also thought gnome-applet but it's need to be implemented per the desktop
> panel library and gnome-panel is no longer available in Fedora. So I think
> gnome-applet is not an option now.
> 
> https://codereview.appspot.com/9462047/diff/18001/ui/gtk3/property.vala
> File ui/gtk3/property.vala (right):
> 
>
https://codereview.appspot.com/9462047/diff/18001/ui/gtk3/property.vala#newco...
> ui/gtk3/property.vala:38: show_icon();
> On 2013/09/09 14:40:51, Peng wrote:
> > Still not very clear for me. Why setting_show is true, you call show_icon(),
> but
> > when it is false, you call m_property_icon.set_visible(false). It is not
> > consistent 
> 
> Done.

Revised the patch.