Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 94560043: code review 94560043: runtime: revise the document of Version() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by minux1
Modified:
10 years, 11 months ago
Reviewers:
gobot, rsc
CC:
iant, rsc, golang-codereviews
Visibility:
Public.

Description

runtime: revise the document of Version() Fixes issue 7701. (again, differently)

Patch Set 1 #

Patch Set 2 : diff -r 2cd1027581fa https://code.google.com/p/go #

Patch Set 3 : diff -r 2cd1027581fa https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 3ce9df24b8d5 https://code.google.com/p/go #

Patch Set 5 : diff -r 3ce9df24b8d5 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M src/pkg/runtime/extern.go View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5
minux1
Hello iant@golang.org, rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 11 months ago (2014-05-17 21:39:03 UTC) #1
rsc
LGTM https://codereview.appspot.com/94560043/diff/40001/src/pkg/runtime/extern.go File src/pkg/runtime/extern.go (right): https://codereview.appspot.com/94560043/diff/40001/src/pkg/runtime/extern.go#newcode193 src/pkg/runtime/extern.go:193: // It is either a string containing the ...
10 years, 11 months ago (2014-05-19 14:02:28 UTC) #2
rsc
In your CL descrpition the period must follow the number or else it will not ...
10 years, 11 months ago (2014-05-19 14:02:51 UTC) #3
minux1
*** Submitted as https://code.google.com/p/go/source/detail?r=f909647ed5e5 *** runtime: revise the document of Version() Fixes issue 7701. (again, ...
10 years, 11 months ago (2014-05-20 18:41:27 UTC) #4
gobot
10 years, 11 months ago (2014-05-20 23:16:20 UTC) #5
Message was sent while issue was closed.
This CL appears to have broken the linux-arm-cheney-panda builder.
See http://build.golang.org/log/5817175fb8f653287e0ac8f443f161cd3501f87d
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b