Issue 94500044: Refactored to use refactored charm-helpers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 94500044: Refactored to use refactored charm-helpers

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by johnsca

Modified:
9 years, 11 months ago

Reviewers:
benjamin.saller, mp+219916

Visibility:
Public.

Description

Refactored to use refactored charm-helpers https://code.launchpad.net/~johnsca/charms/trusty/cf-logrouter/refactor/+merge/219916 (do not edit description out of merge proposal)

Patch Set 2 : Refactored to use refactored charm-helpers #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+745 lines, -433 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	config.yaml	View		1 chunk	+19 lines, -0 lines	0 comments	Download
M	hooks/charmhelpers/contrib/cloudfoundry/common.py	View		2 chunks	+3 lines, -62 lines	0 comments	Download
D	hooks/charmhelpers/contrib/cloudfoundry/config_helper.py	View		1 chunk	+0 lines, -11 lines	0 comments	Download
M	hooks/charmhelpers/contrib/cloudfoundry/contexts.py	View	1	2 chunks	+26 lines, -54 lines	0 comments	Download
D	hooks/charmhelpers/contrib/cloudfoundry/install.py	View		1 chunk	+0 lines, -35 lines	0 comments	Download
D	hooks/charmhelpers/contrib/cloudfoundry/services.py	View		1 chunk	+0 lines, -118 lines	0 comments	Download
D	hooks/charmhelpers/contrib/cloudfoundry/upstart_helper.py	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	hooks/charmhelpers/contrib/hahelpers/apache.py	View		1 chunk	+9 lines, -8 lines	0 comments	Download
M	hooks/charmhelpers/contrib/openstack/context.py	View	1	11 chunks	+107 lines, -26 lines	0 comments	Download
M	hooks/charmhelpers/contrib/openstack/neutron.py	View	1	7 chunks	+31 lines, -5 lines	0 comments	Download
M	hooks/charmhelpers/contrib/openstack/utils.py	View	1	4 chunks	+9 lines, -1 line	0 comments	Download
M	hooks/charmhelpers/contrib/storage/linux/lvm.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	hooks/charmhelpers/contrib/storage/linux/utils.py	View	1	3 chunks	+28 lines, -5 lines	0 comments	Download
M	hooks/charmhelpers/core/hookenv.py	View	1	2 chunks	+98 lines, -1 line	0 comments	Download
M	hooks/charmhelpers/core/host.py	View	1	3 chunks	+47 lines, -0 lines	0 comments	Download
A	hooks/charmhelpers/core/services.py	View		1 chunk	+84 lines, -0 lines	0 comments	Download
A	hooks/charmhelpers/core/templating.py	View	1	1 chunk	+158 lines, -0 lines	0 comments	Download
M	hooks/charmhelpers/fetch/__init__.py	View	1	11 chunks	+97 lines, -65 lines	0 comments	Download
M	hooks/hooks.py	View	1	2 chunks	+17 lines, -16 lines	0 comments	Download
M	hooks/install	View	1	3 chunks	+10 lines, -12 lines	0 comments	Download
M	templates/trafficcontroller.conf	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

benjamin.saller

LGTM +1 https://codereview.appspot.com/94500044/diff/1/hooks/hooks.py File hooks/hooks.py (left): https://codereview.appspot.com/94500044/diff/1/hooks/hooks.py#oldcode18 hooks/hooks.py:18: fileproperties = {'owner': 'vcap'} Do we care ...

9 years, 11 months ago (2014-05-19 19:00:21 UTC) #2

johnsca

9 years, 11 months ago (2014-05-20 22:05:23 UTC) #3

*** Submitted:

Refactored to use refactored charm-helpers

R=benjamin.saller
CC=
https://codereview.appspot.com/94500044

Expand All Messages | Collapse All Messages