Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7407)

Issue 9449044: Make resizing textareas not bounce.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by bac
Modified:
10 years, 11 months ago
Reviewers:
mp+164267, benji, luca.paulina, gary.poster
Visibility:
Public.

Description

Make resizing textareas not bounce. The box was tightly sized to the text so adding new lines caused a temporary bounce/jiggle/shimmy[1]. Solution crafted working with Rick, Huw, Curtis, and Luca was to add some room to grow when the textarea gains focus and then remove it on blur. The effect is quite nice and Luca gave it a thumbs up from a UX standpoint, though I'll seek his final review on this branch. https://code.launchpad.net/~bac/juju-gui/bouncy/+merge/164267 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make resizing textareas not bounce. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M Makefile View 1 chunk +1 line, -0 lines 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/assets/javascripts/resizing_textarea.js View 3 chunks +21 lines, -0 lines 0 comments Download
M test/test_resizing_textarea.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5
bac
Please take a look.
10 years, 11 months ago (2013-05-16 21:06:39 UTC) #1
gary.poster
LGTM. It qas very nicely on Chrome, FF and IE 10. Thank you for bringing ...
10 years, 11 months ago (2013-05-17 12:15:19 UTC) #2
benji
Cool, LGTM. https://codereview.appspot.com/9449044/diff/1/Makefile File Makefile (right): https://codereview.appspot.com/9449044/diff/1/Makefile#newcode35 Makefile:35: -e '^app/assets/javascripts/FileSaver.js$$' \ Something for the future: ...
10 years, 11 months ago (2013-05-17 12:21:36 UTC) #3
luca.paulina
LGTM On 2013/05/17 12:21:36, benji wrote: > Cool, LGTM. > > https://codereview.appspot.com/9449044/diff/1/Makefile > File Makefile ...
10 years, 11 months ago (2013-05-17 13:47:26 UTC) #4
bac
10 years, 11 months ago (2013-05-17 13:57:32 UTC) #5
*** Submitted:

Make resizing textareas not bounce.

The box was tightly sized to the text so adding new lines caused a temporary
bounce/jiggle/shimmy[1].  Solution crafted working with Rick, Huw, Curtis, and
Luca was to add some room to grow when the textarea gains focus and then
remove it on blur.  The effect is quite nice and Luca gave it a thumbs up from
a UX standpoint, though I'll seek his final review on this branch.

R=gary.poster, benji, luca.paulina
CC=
https://codereview.appspot.com/9449044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b