Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(793)

Issue 9445043: Fixes url regression caused by login system

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by jeff.pihach
Modified:
10 years, 10 months ago
Reviewers:
bac, mp+164217, matthew.scott
Visibility:
Public.

Description

Fixes url regression caused by login system This branch fixes a regression that caused directly visited urls to redirect to / after the view had rendered. This also adds in auto redirect to the last url if the user needs to log in. Allowing them to share urls but still maintain the login system and not be forced to navigate again. *note* Because prod doesn't redirect 404's to root we can't test the login redirect. https://code.launchpad.net/~hatch/juju-gui/auth-url-fix/+merge/164217 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 14

Patch Set 2 : Fixes url regression caused by login system #

Patch Set 3 : Fixes url regression caused by login system #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -19 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 7 chunks +74 lines, -19 lines 0 comments Download
M app/views/topology/relation.js View 1 1 chunk +5 lines, -0 lines 0 comments Download
M test/test_app.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
jeff.pihach
Please take a look.
10 years, 10 months ago (2013-05-16 15:37:20 UTC) #1
bac
LGTM with requested code style changes. QA was fine after initial hiccup. https://codereview.appspot.com/9445043/diff/1/app/app.js File app/app.js ...
10 years, 10 months ago (2013-05-16 17:04:15 UTC) #2
jeff.pihach
Thanks for the review! Changes made. https://codereview.appspot.com/9445043/diff/1/app/app.js File app/app.js (right): https://codereview.appspot.com/9445043/diff/1/app/app.js#newcode274 app/app.js:274: // If this ...
10 years, 10 months ago (2013-05-16 17:27:22 UTC) #3
jeff.pihach
Please take a look.
10 years, 10 months ago (2013-05-16 17:30:53 UTC) #4
matthew.scott
LGTM - thnks for the fix!
10 years, 10 months ago (2013-05-16 18:58:58 UTC) #5
jeff.pihach
10 years, 10 months ago (2013-05-16 19:06:52 UTC) #6
*** Submitted:

Fixes url regression caused by login system

This branch fixes a regression that caused directly
visited urls to redirect to / after the view had 
rendered. 

This also adds in auto redirect to the last url if
the user needs to log in. Allowing them to share urls
but still maintain the login system and not be forced
to navigate again.

*note* Because prod doesn't redirect 404's to root we
can't test the login redirect.

R=bac, matthew.scott
CC=
https://codereview.appspot.com/9445043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b