Issue 9440043: code review 9440043: runtime: fix scanning of not started goroutines

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9440043: code review 9440043: runtime: fix scanning of not started goroutines (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by cshapiro1

Modified:
11 years ago

Reviewers:

CC:
golang-dev, bradfitz, iant, dvyukov

Visibility:
Public.

Description

runtime: fix scanning of not started goroutines The stack scanner for not started goroutines ignored the arguments area when its size was unknown. With this change, the distance between the stack pointer and the stack base will be used instead. Fixes issue 5486

Patch Set 1 #

Patch Set 2 : diff -r 0d28fd55e721 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 0d28fd55e721 https://code.google.com/p/go/ #

Patch Set 4 : diff -r e4df8909ab83 https://code.google.com/p/go/ #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	src/pkg/runtime/mgc0.c	View	1	1 chunk	+10 lines, -3 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

cshapiro1

Testing suggestions would be welcomed. Do we have a way to leave a goroutine in ...

11 years ago (2013-05-16 04:23:33 UTC) #1

cshapiro1

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years ago (2013-05-16 04:24:27 UTC) #2

bradfitz

Testing: Start a bunch of goroutines in a loop and then call GC. On May ...

11 years ago (2013-05-16 04:27:46 UTC) #3

iant

Patch LGTM I agree with bradfitz about how to get a goroutine in the not-yet-started ...

11 years ago (2013-05-16 04:29:34 UTC) #4

cshapiro1

I have a test ready but I am not happy with its dependencies. I suspect ...

11 years ago (2013-05-16 17:39:17 UTC) #6

cshapiro1

11 years ago (2013-05-16 17:42:43 UTC) #7

*** Submitted as https://code.google.com/p/go/source/detail?r=3623b5f14f72 ***

runtime: fix scanning of not started goroutines

The stack scanner for not started goroutines ignored the arguments
area when its size was unknown.  With this change, the distance
between the stack pointer and the stack base will be used instead.

Fixes issue 5486

R=golang-dev, bradfitz, iant, dvyukov
CC=golang-dev
https://codereview.appspot.com/9440043

Expand All Messages | Collapse All Messages