Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(631)

Issue 9438043: code review 9438043: rsa: Implementation of RSASSA-PSS signature algorithm a...

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by Nan Deng
Modified:
9 years, 4 months ago
Reviewers:
CC:
agl, agl1, gobot, golang-dev, r
Visibility:
Public.

Description

rsa: Implementation of RSASSA-PSS signature algorithm and its corresponding test cases Implementation of RSASSA-PSS signature algorithm described in RFC 3447 and its corresponding test cases. There are two test files: - emsa_test.go: Test on EMSA-PSS encoding/decoding scheme - pssvect_test.go: Test on the signature algorithm itself. All cases are generated from the test vectors provided by RSA Lab, which can be downloaded from ftp://ftp.rsasecurity.com/pub/pkcs/pkcs-1/pkcs-1v2-1-vec.zip

Patch Set 1 #

Patch Set 2 : diff -r 1abed5873071 https://code.google.com/p/go #

Patch Set 3 : diff -r 1abed5873071 https://code.google.com/p/go #

Total comments: 43

Patch Set 4 : diff -r 1abed5873071 https://code.google.com/p/go #

Patch Set 5 : diff -r 1abed5873071 https://code.google.com/p/go #

Patch Set 6 : diff -r 1abed5873071 https://code.google.com/p/go #

Patch Set 7 : diff -r 1abed5873071 https://code.google.com/p/go #

Total comments: 2

Patch Set 8 : diff -r 1abed5873071 https://code.google.com/p/go #

Patch Set 9 : diff -r 1abed5873071 https://code.google.com/p/go #

Patch Set 10 : diff -r 1abed5873071 https://code.google.com/p/go #

Patch Set 11 : diff -r 1abed5873071 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -0 lines) Patch
A src/pkg/crypto/rsa/emsa_test.go View 1 2 3 1 chunk +33 lines, -0 lines 0 comments Download
A src/pkg/crypto/rsa/pss.go View 1 2 3 4 5 6 7 8 9 1 chunk +224 lines, -0 lines 0 comments Download
A src/pkg/crypto/rsa/pssvect_test.go View 1 2 3 4 5 6 7 8 9 1 chunk +90 lines, -0 lines 0 comments Download

Messages

Total messages: 18
Nan Deng
Hello golang-dev@googlegroups.com (cc: agl@golang.org), I'd like you to review this change to https://code.google.com/p/go
9 years, 4 months ago (2013-05-15 22:01:31 UTC) #1
r
Does this need to be in the main repo? The go.crypt repo seems fine to ...
9 years, 4 months ago (2013-05-15 22:04:02 UTC) #2
Nan Deng
In rsa.go, line 8, there is a TODO says " TODO(agl): Add support for PSS ...
9 years, 4 months ago (2013-05-15 22:14:40 UTC) #3
gobot
R=agl (assigned by minux)
9 years, 4 months ago (2013-05-16 10:13:20 UTC) #4
agl1
Haven't looked at the tests yet. https://codereview.appspot.com/9438043/diff/5001/src/pkg/crypto/rsa/pss.go File src/pkg/crypto/rsa/pss.go (right): https://codereview.appspot.com/9438043/diff/5001/src/pkg/crypto/rsa/pss.go#newcode2 src/pkg/crypto/rsa/pss.go:2: Should have a ...
9 years, 4 months ago (2013-05-17 15:18:54 UTC) #5
Nan Deng
Hello agl@chromium.org, agl@golang.org (cc: gobot@golang.org, golang-dev@googlegroups.com, r@golang.org), Please take another look.
9 years, 4 months ago (2013-05-17 19:52:57 UTC) #6
Nan Deng
Changed the pss.go according to agl's advise. Removed most test cases from pssvect_test.go. Only two ...
9 years, 4 months ago (2013-05-17 19:55:51 UTC) #7
Nan Deng
Hello agl@chromium.org, agl@golang.org (cc: gobot@golang.org, golang-dev@googlegroups.com, r@golang.org), Please take another look.
9 years, 4 months ago (2013-05-17 20:02:11 UTC) #8
Nan Deng
Fixed all parts according to agl's advise. https://codereview.appspot.com/9438043/diff/5001/src/pkg/crypto/rsa/pss.go File src/pkg/crypto/rsa/pss.go (right): https://codereview.appspot.com/9438043/diff/5001/src/pkg/crypto/rsa/pss.go#newcode2 src/pkg/crypto/rsa/pss.go:2: On 2013/05/17 ...
9 years, 4 months ago (2013-05-17 20:03:23 UTC) #9
agl1
https://codereview.appspot.com/9438043/diff/20001/src/pkg/crypto/rsa/pss.go File src/pkg/crypto/rsa/pss.go (right): https://codereview.appspot.com/9438043/diff/20001/src/pkg/crypto/rsa/pss.go#newcode190 src/pkg/crypto/rsa/pss.go:190: func SignPSS(rand io.Reader, priv *PrivateKey, hash crypto.Hash, hashed []byte, ...
9 years, 4 months ago (2013-05-20 19:56:23 UTC) #10
Nan Deng
https://codereview.appspot.com/9438043/diff/20001/src/pkg/crypto/rsa/pss.go File src/pkg/crypto/rsa/pss.go (right): https://codereview.appspot.com/9438043/diff/20001/src/pkg/crypto/rsa/pss.go#newcode190 src/pkg/crypto/rsa/pss.go:190: func SignPSS(rand io.Reader, priv *PrivateKey, hash crypto.Hash, hashed []byte, ...
9 years, 4 months ago (2013-05-20 20:19:58 UTC) #11
Nan Deng
Hello agl@chromium.org, agl@golang.org (cc: gobot@golang.org, golang-dev@googlegroups.com, r@golang.org), Please take another look.
9 years, 4 months ago (2013-05-20 20:23:43 UTC) #12
Nan Deng
Hello agl@chromium.org, agl@golang.org (cc: gobot@golang.org, golang-dev@googlegroups.com, r@golang.org), Please take another look.
9 years, 4 months ago (2013-05-20 20:26:40 UTC) #13
agl1
Have you signed the CLA? http://golang.org/doc/contribute.html#copyright I altered the code to be compatible with OpenSSL's ...
9 years, 4 months ago (2013-05-22 20:21:02 UTC) #14
Nan Deng
On 2013/05/22 20:21:02, agl1 wrote: > Have you signed the CLA? http://golang.org/doc/contribute.html#copyright > Just signed ...
9 years, 4 months ago (2013-05-22 20:52:58 UTC) #15
agl
On Wed, May 22, 2013 at 4:52 PM, <monnand@gmail.com> wrote: > Just signed it. It ...
9 years, 4 months ago (2013-05-22 20:56:39 UTC) #16
Nan Deng
On 2013/05/22 20:56:39, agl wrote: > On Wed, May 22, 2013 at 4:52 PM, <mailto:monnand@gmail.com> ...
9 years, 4 months ago (2013-05-22 21:17:35 UTC) #17
agl1
9 years, 4 months ago (2013-05-23 15:10:51 UTC) #18
*** Submitted as https://code.google.com/p/go/source/detail?r=0fb55e40bd0c ***

crypto/rsa: implement PSS signatures.

This change contains an implementation of the RSASSA-PSS signature
algorithm described in RFC 3447.

R=agl, agl
CC=gobot, golang-dev, r
https://codereview.appspot.com/9438043

Committer: Adam Langley <agl@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b