Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(348)

Issue 94340043: Issue 463: Provide a signout\logout method (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years ago by peleyal
Modified:
5 years ago
Reviewers:
class
CC:
google-api-dotnet-client_googlegroups.com
Base URL:
https://google-api-dotnet-client.googlecode.com/hg/
Visibility:
Public.

Description

Issue 463: Provide a signout\logout method

Patch Set 1 #

Patch Set 2 : Update code for WP and WinRT #

Patch Set 3 : minor #

Patch Set 4 : minor II #

Patch Set 5 : minor III #

Total comments: 30

Patch Set 6 : Gus' comments #

Patch Set 7 : error in reviewing - uploading again #

Total comments: 4

Patch Set 8 : Gus' comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -43 lines) Patch
M Src/GoogleApis.Auth.DotNet4/OAuth2/GoogleWebAuthorizationBroker.cs View 1 2 3 4 5 6 7 2 chunks +21 lines, -4 lines 0 comments Download
M Src/GoogleApis.Auth.WP/OAuth2/AuthorizationCodeBroker.cs View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M Src/GoogleApis.Auth.WP/OAuth2/AuthorizationCodeWPInstalledApp.cs View 1 2 3 4 5 6 7 1 chunk +13 lines, -2 lines 0 comments Download
M Src/GoogleApis.Auth.WP/OAuth2/GoogleWebAuthorizationBroker.cs View 1 2 3 4 5 6 7 2 chunks +21 lines, -3 lines 0 comments Download
M Src/GoogleApis.Auth.WP/OAuth2/WebAuthenticationBrokerUserControl.xaml.cs View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.Auth.WinRT/OAuth2/AuthorizationCodeWinRTInstalledApp.cs View 1 2 3 4 5 6 7 2 chunks +16 lines, -12 lines 0 comments Download
M Src/GoogleApis.Auth.WinRT/OAuth2/GoogleWebAuthorizationBroker.cs View 1 2 3 4 5 6 7 1 chunk +18 lines, -1 line 0 comments Download
M Src/GoogleApis.Auth/GoogleApis.Auth.csproj View 1 chunk +1 line, -0 lines 0 comments Download
M Src/GoogleApis.Auth/OAuth2/AuthorizationCodeInstalledApp.cs View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Src/GoogleApis.Auth/OAuth2/Flows/AuthorizationCodeFlow.cs View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M Src/GoogleApis.Auth/OAuth2/Flows/GoogleAuthorizationCodeFlow.cs View 1 2 3 4 5 6 7 4 chunks +36 lines, -1 line 0 comments Download
M Src/GoogleApis.Auth/OAuth2/Flows/IAuthorizationCodeFlow.cs View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
M Src/GoogleApis.Auth/OAuth2/GoogleConsts.cs View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth/OAuth2/Requests/GoogleRevokeTokenRequest.cs View 1 2 3 4 5 1 chunk +57 lines, -0 lines 0 comments Download
M Src/GoogleApis.Auth/OAuth2/UserCredential.cs View 1 2 3 4 5 6 chunks +59 lines, -15 lines 0 comments Download
M Src/GoogleApis.Auth/OAuth2/Web/AuthorizationCodeWebApp.cs View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
peleyal
Hi Gus, This is a new feature for 1.8.2. It includes a code for revoking ...
5 years ago (2014-05-12 14:12:23 UTC) #1
class
LGTM, a few comments on comments... https://codereview.appspot.com/94340043/diff/70001/Src/GoogleApis.Auth.DotNet4/OAuth2/GoogleWebAuthorizationBroker.cs File Src/GoogleApis.Auth.DotNet4/OAuth2/GoogleWebAuthorizationBroker.cs (left): https://codereview.appspot.com/94340043/diff/70001/Src/GoogleApis.Auth.DotNet4/OAuth2/GoogleWebAuthorizationBroker.cs#oldcode87 Src/GoogleApis.Auth.DotNet4/OAuth2/GoogleWebAuthorizationBroker.cs:87: /// <param name="scopes"> ...
5 years ago (2014-05-12 18:00:54 UTC) #2
peleyal
I'm not submitting before getting your final approval. Thanks for all the comments, see you ...
5 years ago (2014-05-12 20:26:34 UTC) #3
class
Two small typos and you're good to go. https://codereview.appspot.com/94340043/diff/50031/Src/GoogleApis.Auth.WP/OAuth2/AuthorizationCodeWPInstalledApp.cs File Src/GoogleApis.Auth.WP/OAuth2/AuthorizationCodeWPInstalledApp.cs (right): https://codereview.appspot.com/94340043/diff/50031/Src/GoogleApis.Auth.WP/OAuth2/AuthorizationCodeWPInstalledApp.cs#newcode41 Src/GoogleApis.Auth.WP/OAuth2/AuthorizationCodeWPInstalledApp.cs:41: /// ...
5 years ago (2014-05-12 22:54:44 UTC) #4
peleyal
5 years ago (2014-05-14 15:45:24 UTC) #5
Thanks. Submitting now

https://codereview.appspot.com/94340043/diff/50031/Src/GoogleApis.Auth.WP/OAu...
File Src/GoogleApis.Auth.WP/OAuth2/AuthorizationCodeWPInstalledApp.cs (right):

https://codereview.appspot.com/94340043/diff/50031/Src/GoogleApis.Auth.WP/OAu...
Src/GoogleApis.Auth.WP/OAuth2/AuthorizationCodeWPInstalledApp.cs:41: ///
<summary>Constructs a new authorization code installed application for Window
Phone.</summary>
On 2014/05/12 22:54:44, class wrote:
> Windows Phone (missing the S)

Done.

https://codereview.appspot.com/94340043/diff/50031/Src/GoogleApis.Auth.WP/OAu...
Src/GoogleApis.Auth.WP/OAuth2/AuthorizationCodeWPInstalledApp.cs:49: ///
<summary>Constructs a new authorization code installed application for Windows
Phone.</summary>
On 2014/05/12 22:54:44, class wrote:
> Please update the summary, it's not clear what this does still. 
> 
> My first guess is "Authorizes the app using an authorization code flow,
> targeting an installed app."

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b