Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(559)

Issue 9429043: code review 9429043: misc/cgo/test: add missing import (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by brainman
Modified:
11 years, 11 months ago
Reviewers:
minux1, bradfitz
CC:
golang-dev
Visibility:
Public.

Description

misc/cgo/test: add missing import Fixes windows build.

Patch Set 1 #

Patch Set 2 : diff -r 3fc2a3f9584a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3fc2a3f9584a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 3fc2a3f9584a https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M misc/cgo/test/issue5337w.go View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
brainman
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 11 months ago (2013-05-15 05:26:23 UTC) #1
brainman
*** Submitted as https://code.google.com/p/go/source/detail?r=ebe8bca920ad *** misc/cgo/test: add missing import Fixes windows build. R=golang-dev CC=golang-dev https://codereview.appspot.com/9429043
11 years, 11 months ago (2013-05-15 05:34:59 UTC) #2
bradfitz
LGTM But try to run code before submitting it. On May 14, 2013 10:26 PM, ...
11 years, 11 months ago (2013-05-15 05:49:10 UTC) #3
brainman
On 2013/05/15 05:49:10, bradfitz wrote: > ... > But try to run code before submitting ...
11 years, 11 months ago (2013-05-15 05:50:49 UTC) #4
minux1
11 years, 11 months ago (2013-05-15 08:13:19 UTC) #5
Thank you.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b