Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(341)

Issue 9418050: IDL roll to multivm@1242 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by vsm
Modified:
9 years, 4 months ago
Reviewers:
antonm1, blois
CC:
reviews_dartlang.org
Base URL:
https://dart.googlecode.com/svn/third_party/WebCore
Visibility:
Public.

Description

IDL roll to multivm@1242 TBR=blois Committed: 22811

Patch Set 1 #

Total comments: 12
Unified diffs Side-by-side diffs Delta from patch set Stats (+1822 lines, -643 lines) Patch
M core/README View 1 chunk +1 line, -1 line 0 comments Download
A core/core.gyp/scripts/action_csspropertynames.py View 1 chunk +174 lines, -0 lines 0 comments Download
A core/core.gyp/scripts/action_cssvaluekeywords.py View 1 chunk +178 lines, -0 lines 0 comments Download
A core/core.gyp/scripts/action_derivedsourcesallinone.py View 1 chunk +225 lines, -0 lines 0 comments Download
A core/core.gyp/scripts/action_makenames.py View 1 chunk +182 lines, -0 lines 0 comments Download
A core/core.gyp/scripts/action_useragentstylesheets.py View 1 chunk +124 lines, -0 lines 0 comments Download
A core/core.gyp/scripts/rule_bison.py View 1 chunk +105 lines, -0 lines 0 comments Download
A core/core.gyp/scripts/supplemental_idl_files.py View 1 chunk +45 lines, -0 lines 0 comments Download
M core/css/CSSFontFaceLoadEvent.idl View 1 chunk +0 lines, -1 line 1 comment Download
M core/css/CSSHostRule.idl View 1 chunk +1 line, -3 lines 0 comments Download
M core/css/CSSRule.idl View 1 chunk +0 lines, -2 lines 1 comment Download
M core/css/CSSSupportsRule.idl View 2 chunks +1 line, -4 lines 0 comments Download
M core/css/DOMWindowCSS.idl View 1 chunk +1 line, -2 lines 0 comments Download
M core/css/FontLoader.idl View 2 chunks +1 line, -2 lines 0 comments Download
M core/dom/CustomElementConstructor.idl View 1 chunk +0 lines, -1 line 1 comment Download
M core/dom/DOMNamedFlowCollection.idl View 1 chunk +1 line, -2 lines 0 comments Download
M core/dom/DataTransferItem.idl View 1 chunk +1 line, -1 line 0 comments Download
D core/dom/DeviceAcceleration.idl View 1 chunk +0 lines, -32 lines 0 comments Download
D core/dom/DeviceMotionEvent.idl View 1 chunk +0 lines, -38 lines 1 comment Download
D core/dom/DeviceRotationRate.idl View 1 chunk +0 lines, -32 lines 0 comments Download
M core/dom/Document.idl View 3 chunks +11 lines, -13 lines 0 comments Download
M core/dom/Element.idl View 3 chunks +7 lines, -7 lines 0 comments Download
M core/dom/RequestAnimationFrameCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
M core/dom/SecurityPolicyViolationEvent.idl View 1 chunk +1 line, -0 lines 0 comments Download
M core/dom/StringCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
M core/dom/Text.idl View 2 chunks +3 lines, -2 lines 0 comments Download
M core/html/HTMLAudioElement.idl View 1 chunk +0 lines, -1 line 1 comment Download
M core/html/HTMLCollection.idl View 2 chunks +1 line, -2 lines 0 comments Download
M core/html/HTMLDialogElement.idl View 1 chunk +0 lines, -1 line 1 comment Download
M core/html/HTMLInputElement.idl View 2 chunks +4 lines, -4 lines 0 comments Download
M core/html/HTMLMediaElement.idl View 2 chunks +6 lines, -1 line 0 comments Download
M core/html/HTMLSourceElement.idl View 1 chunk +3 lines, -5 lines 0 comments Download
M core/html/HTMLVideoElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M core/html/MediaController.idl View 1 chunk +0 lines, -1 line 0 comments Download
M core/html/MediaError.idl View 1 chunk +0 lines, -1 line 0 comments Download
M core/html/TimeRanges.idl View 1 chunk +0 lines, -1 line 0 comments Download
M core/html/VoidCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
A + core/html/canvas/Canvas2DContextAttributes.idl View 2 chunks +3 lines, -9 lines 0 comments Download
D core/html/canvas/CanvasProxy.idl View 1 chunk +0 lines, -30 lines 0 comments Download
M core/html/canvas/CanvasRenderingContext2D.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M core/html/canvas/Float32Array.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M core/html/canvas/Float64Array.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M core/html/canvas/Int16Array.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M core/html/canvas/Int32Array.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M core/html/canvas/Int8Array.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M core/html/canvas/OESTextureHalfFloat.idl View 1 chunk +4 lines, -0 lines 0 comments Download
M core/html/canvas/Uint16Array.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M core/html/canvas/Uint32Array.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M core/html/canvas/Uint8Array.idl View 1 chunk +0 lines, -2 lines 1 comment Download
M core/html/canvas/Uint8ClampedArray.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M core/html/canvas/WebGLRenderingContext.idl View 4 chunks +0 lines, -6 lines 0 comments Download
M core/html/shadow/HTMLContentElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
M core/html/shadow/HTMLShadowElement.idl View 1 chunk +1 line, -3 lines 0 comments Download
M core/inspector/CodeGeneratorInspector.py View 1 chunk +14 lines, -6 lines 0 comments Download
M core/inspector/CodeGeneratorInspectorStrings.py View 4 chunks +7 lines, -7 lines 0 comments Download
M core/page/DOMWindow.idl View 13 chunks +24 lines, -26 lines 0 comments Download
M core/page/DOMWindowPagePopup.idl View 1 chunk +1 line, -2 lines 0 comments Download
M core/page/Performance.idl View 2 chunks +16 lines, -7 lines 0 comments Download
D core/page/PerformanceEntryList.idl View 1 chunk +0 lines, -39 lines 0 comments Download
M core/plugins/DOMMimeTypeArray.idl View 1 chunk +1 line, -2 lines 0 comments Download
M core/plugins/DOMPlugin.idl View 2 chunks +1 line, -2 lines 0 comments Download
M core/plugins/DOMPluginArray.idl View 1 chunk +1 line, -2 lines 0 comments Download
A core/scripts/in_file.py View 1 chunk +119 lines, -0 lines 0 comments Download
A core/scripts/in_file_unittest.py View 1 chunk +77 lines, -0 lines 0 comments Download
A core/scripts/in_generator.py View 1 chunk +90 lines, -0 lines 0 comments Download
A core/scripts/license.py View 1 chunk +62 lines, -0 lines 0 comments Download
A core/scripts/make_runtime_features.py View 1 chunk +144 lines, -0 lines 0 comments Download
M core/testing/InternalSettings.idl View 2 chunks +1 line, -2 lines 0 comments Download
M core/testing/Internals.idl View 5 chunks +5 lines, -7 lines 0 comments Download
M core/workers/DedicatedWorkerContext.idl View 1 chunk +1 line, -5 lines 0 comments Download
M core/workers/SharedWorker.idl View 1 chunk +0 lines, -1 line 1 comment Download
M core/workers/SharedWorkerContext.idl View 1 chunk +1 line, -6 lines 0 comments Download
M core/workers/WorkerContext.idl View 1 chunk +0 lines, -1 line 0 comments Download
M modules/README View 1 chunk +1 line, -1 line 0 comments Download
M modules/battery/NavigatorBattery.idl View 1 chunk +1 line, -2 lines 0 comments Download
A + modules/device_orientation/DeviceAcceleration.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + modules/device_orientation/DeviceMotionEvent.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + modules/device_orientation/DeviceRotationRate.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
M modules/donottrack/NavigatorDoNotTrack.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/filesystem/DOMWindowFileSystem.idl View 1 chunk +3 lines, -5 lines 0 comments Download
M modules/filesystem/DataTransferItemFileSystem.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/filesystem/DirectoryEntry.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M modules/filesystem/DirectoryReader.idl View 1 chunk +1 line, -1 line 0 comments Download
M modules/filesystem/EntriesCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/filesystem/Entry.idl View 1 chunk +5 lines, -5 lines 0 comments Download
M modules/filesystem/EntryCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/filesystem/ErrorCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/filesystem/FileCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/filesystem/FileEntry.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M modules/filesystem/FileSystemCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/filesystem/FileWriterCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/filesystem/HTMLInputElementFileSystem.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/filesystem/MetadataCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/filesystem/WorkerContextFileSystem.idl View 1 chunk +3 lines, -5 lines 0 comments Download
M modules/gamepad/Gamepad.idl View 1 chunk +0 lines, -1 line 1 comment Download
M modules/gamepad/GamepadList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M modules/gamepad/NavigatorGamepad.idl View 1 chunk +1 line, -4 lines 0 comments Download
M modules/geolocation/NavigatorGeolocation.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/geolocation/PositionCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/geolocation/PositionErrorCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/indexeddb/DOMWindowIndexedDatabase.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/indexeddb/WorkerContextIndexedDatabase.idl View 1 chunk +3 lines, -5 lines 1 comment Download
A + modules/inputmethod/Composition.idl View 1 chunk +5 lines, -3 lines 0 comments Download
A + modules/inputmethod/InputMethodContext.idl View 1 chunk +11 lines, -4 lines 0 comments Download
M modules/mediastream/DOMWindowMediaStream.idl View 1 chunk +3 lines, -4 lines 0 comments Download
D modules/mediastream/LocalMediaStream.idl View 1 chunk +0 lines, -31 lines 0 comments Download
M modules/mediastream/MediaStream.idl View 2 chunks +1 line, -1 line 0 comments Download
M modules/mediastream/NavigatorMediaStream.idl View 1 chunk +4 lines, -5 lines 0 comments Download
M modules/mediastream/NavigatorUserMediaErrorCallback.idl View 1 chunk +2 lines, -3 lines 0 comments Download
M modules/mediastream/NavigatorUserMediaSuccessCallback.idl View 1 chunk +2 lines, -3 lines 0 comments Download
M modules/mediastream/RTCErrorCallback.idl View 1 chunk +2 lines, -3 lines 0 comments Download
M modules/mediastream/RTCPeerConnection.idl View 2 chunks +5 lines, -5 lines 0 comments Download
M modules/mediastream/RTCSessionDescriptionCallback.idl View 1 chunk +2 lines, -3 lines 0 comments Download
M modules/mediastream/RTCStatsCallback.idl View 1 chunk +2 lines, -3 lines 0 comments Download
M modules/mediastream/RTCStatsResponse.idl View 1 chunk +2 lines, -3 lines 0 comments Download
M modules/navigatorcontentutils/NavigatorContentUtils.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/notifications/DOMWindowNotifications.idl View 1 chunk +1 line, -2 lines 0 comments Download
M modules/notifications/Notification.idl View 1 chunk +1 line, -1 line 0 comments Download
M modules/notifications/NotificationCenter.idl View 1 chunk +1 line, -1 line 0 comments Download
M modules/notifications/NotificationPermissionCallback.idl View 1 chunk +2 lines, -3 lines 0 comments Download
M modules/notifications/WorkerContextNotifications.idl View 1 chunk +1 line, -2 lines 0 comments Download
M modules/quota/DOMWindowQuota.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M modules/quota/NavigatorStorageQuota.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/quota/StorageErrorCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/quota/StorageInfo.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M modules/quota/StorageQuota.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M modules/quota/StorageQuotaCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/quota/StorageUsageCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/quota/WorkerNavigatorStorageQuota.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/speech/DOMWindowSpeech.idl View 1 chunk +6 lines, -8 lines 0 comments Download
M modules/speech/DOMWindowSpeechSynthesis.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M modules/speech/SpeechSynthesis.idl View 1 chunk +1 line, -1 line 1 comment Download
M modules/speech/SpeechSynthesisEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M modules/speech/SpeechSynthesisUtterance.idl View 1 chunk +1 line, -1 line 0 comments Download
M modules/speech/SpeechSynthesisVoice.idl View 1 chunk +1 line, -1 line 0 comments Download
M modules/vibration/NavigatorVibration.idl View 1 chunk +1 line, -2 lines 0 comments Download
M modules/webaudio/AudioBufferCallback.idl View 1 chunk +2 lines, -3 lines 0 comments Download
M modules/webaudio/AudioBufferSourceNode.idl View 1 chunk +1 line, -3 lines 1 comment Download
M modules/webaudio/AudioContext.idl View 2 chunks +1 line, -5 lines 0 comments Download
M modules/webaudio/AudioParam.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M modules/webaudio/DOMWindowWebAudio.idl View 1 chunk +3 lines, -4 lines 0 comments Download
M modules/webaudio/MediaElementAudioSourceNode.idl View 1 chunk +1 line, -1 line 0 comments Download
M modules/webaudio/OscillatorNode.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M modules/webdatabase/DOMWindowWebDatabase.idl View 1 chunk +2 lines, -4 lines 0 comments Download
M modules/webdatabase/Database.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M modules/webdatabase/DatabaseCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/webdatabase/DatabaseSync.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M modules/webdatabase/SQLStatementCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/webdatabase/SQLStatementErrorCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/webdatabase/SQLTransaction.idl View 1 chunk +3 lines, -2 lines 0 comments Download
M modules/webdatabase/SQLTransactionCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/webdatabase/SQLTransactionErrorCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/webdatabase/SQLTransactionSyncCallback.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/webdatabase/WorkerContextWebDatabase.idl View 1 chunk +4 lines, -6 lines 0 comments Download
A + modules/webmidi/DOMWindowWebMIDI.idl View 1 chunk +3 lines, -5 lines 0 comments Download
A + modules/webmidi/MIDIConnectionEvent.idl View 1 chunk +3 lines, -3 lines 0 comments Download
A + modules/webmidi/MIDIErrorCallback.idl View 1 chunk +2 lines, -4 lines 0 comments Download
A + modules/webmidi/MIDIMessageEvent.idl View 1 chunk +5 lines, -5 lines 0 comments Download
A + modules/webmidi/MIDIPort.idl View 3 chunks +17 lines, -10 lines 0 comments Download
M modules/websockets/DOMWindowWebSocket.idl View 1 chunk +1 line, -3 lines 0 comments Download
M modules/websockets/WorkerContextWebSocket.idl View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2
vsm
Committed patchset #1 manually as r22811 (presubmit successful).
9 years, 4 months ago (2013-05-16 19:40:07 UTC) #1
antonm1
9 years, 4 months ago (2013-05-17 09:38:06 UTC) #2
Message was sent while issue was closed.
DBC

https://codereview.appspot.com/9418050/diff/1/core/css/CSSFontFaceLoadEvent.idl
File core/css/CSSFontFaceLoadEvent.idl (left):

https://codereview.appspot.com/9418050/diff/1/core/css/CSSFontFaceLoadEvent.i...
core/css/CSSFontFaceLoadEvent.idl:32: Conditional=FONT_LOAD_EVENTS,
should ENABLED_FONT_LOAD_EVENTS now be removed from
tools/dom/scripts/fremontcutbuilder.py?

https://codereview.appspot.com/9418050/diff/1/core/css/CSSRule.idl
File core/css/CSSRule.idl (left):

https://codereview.appspot.com/9418050/diff/1/core/css/CSSRule.idl#oldcode39
core/css/CSSRule.idl:39: #if defined(ENABLE_CSS3_CONDITIONAL_RULES) &&
ENABLE_CSS3_CONDITIONAL_RULES
ditto for this ENABLE_

https://codereview.appspot.com/9418050/diff/1/core/dom/CustomElementConstruct...
File core/dom/CustomElementConstructor.idl (left):

https://codereview.appspot.com/9418050/diff/1/core/dom/CustomElementConstruct...
core/dom/CustomElementConstructor.idl:26: Conditional=CUSTOM_ELEMENTS,
and this one, also in DartCustomElement.h

https://codereview.appspot.com/9418050/diff/1/core/dom/DeviceMotionEvent.idl
File core/dom/DeviceMotionEvent.idl (left):

https://codereview.appspot.com/9418050/diff/1/core/dom/DeviceMotionEvent.idl#...
core/dom/DeviceMotionEvent.idl:31: [Custom] void
initDeviceMotionEvent([Default=Undefined] optional DOMString type,
should custom bindings go away now?

https://codereview.appspot.com/9418050/diff/1/core/html/HTMLAudioElement.idl
File core/html/HTMLAudioElement.idl (left):

https://codereview.appspot.com/9418050/diff/1/core/html/HTMLAudioElement.idl#...
core/html/HTMLAudioElement.idl:27: Conditional=VIDEO,
and this ENABLE_VIDEO

https://codereview.appspot.com/9418050/diff/1/core/html/HTMLDialogElement.idl
File core/html/HTMLDialogElement.idl (left):

https://codereview.appspot.com/9418050/diff/1/core/html/HTMLDialogElement.idl...
core/html/HTMLDialogElement.idl:27: Conditional=DIALOG_ELEMENT,
and this ENABLE_DIALOG_ELEMENT

https://codereview.appspot.com/9418050/diff/1/core/html/canvas/Uint8Array.idl
File core/html/canvas/Uint8Array.idl (left):

https://codereview.appspot.com/9418050/diff/1/core/html/canvas/Uint8Array.idl...
core/html/canvas/Uint8Array.idl:29: NumericIndexedGetter,
are those annotations completely removed?  it looks like we still have a logic
for them in tools/dom/scripts.

https://codereview.appspot.com/9418050/diff/1/core/workers/SharedWorker.idl
File core/workers/SharedWorker.idl (left):

https://codereview.appspot.com/9418050/diff/1/core/workers/SharedWorker.idl#o...
core/workers/SharedWorker.idl:33: Conditional=SHARED_WORKERS,
and this ENABLE

https://codereview.appspot.com/9418050/diff/1/modules/gamepad/Gamepad.idl
File modules/gamepad/Gamepad.idl (left):

https://codereview.appspot.com/9418050/diff/1/modules/gamepad/Gamepad.idl#old...
modules/gamepad/Gamepad.idl:27: Conditional=GAMEPAD,
and this ENABLE

https://codereview.appspot.com/9418050/diff/1/modules/indexeddb/WorkerContext...
File modules/indexeddb/WorkerContextIndexedDatabase.idl (left):

https://codereview.appspot.com/9418050/diff/1/modules/indexeddb/WorkerContext...
modules/indexeddb/WorkerContextIndexedDatabase.idl:28:
Supplemental=WorkerContext
if Supplemental is completely off WebKit IDLs, shouldn't we stop supporting it
in our scripts/dart.idl?

https://codereview.appspot.com/9418050/diff/1/modules/speech/SpeechSynthesis.idl
File modules/speech/SpeechSynthesis.idl (left):

https://codereview.appspot.com/9418050/diff/1/modules/speech/SpeechSynthesis....
modules/speech/SpeechSynthesis.idl:27: Conditional=SPEECH_SYNTHESIS
ENABLE again?

https://codereview.appspot.com/9418050/diff/1/modules/webaudio/AudioBufferSou...
File modules/webaudio/AudioBufferSourceNode.idl (left):

https://codereview.appspot.com/9418050/diff/1/modules/webaudio/AudioBufferSou...
modules/webaudio/AudioBufferSourceNode.idl:51: #if
defined(ENABLE_LEGACY_WEB_AUDIO) && ENABLE_LEGACY_WEB_AUDIO
another ENABLE?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b