Code review - Issue 9418050: IDL roll to multivm@1242https://codereview.appspot.com/2013-05-17T09:38:06+00:00rietveld
Message from unknown
2013-05-16T19:36:47+00:00vsmurn:md5:c971ac9ebbd0abe7eb8d272c33a9419a
Message from vsm@google.com
2013-05-16T19:40:07+00:00vsmurn:md5:d90847bc1df829cd6b39ebf06ae2440e
Committed patchset #1 manually as r22811 (presubmit successful).
Message from antonm@google.com
2013-05-17T09:38:06+00:00antonm1urn:md5:1664d3c3a61e0612d304099f074d90a2
DBC
https://codereview.appspot.com/9418050/diff/1/core/css/CSSFontFaceLoadEvent.idl
File core/css/CSSFontFaceLoadEvent.idl (left):
https://codereview.appspot.com/9418050/diff/1/core/css/CSSFontFaceLoadEvent.idl#oldcode32
core/css/CSSFontFaceLoadEvent.idl:32: Conditional=FONT_LOAD_EVENTS,
should ENABLED_FONT_LOAD_EVENTS now be removed from tools/dom/scripts/fremontcutbuilder.py?
https://codereview.appspot.com/9418050/diff/1/core/css/CSSRule.idl
File core/css/CSSRule.idl (left):
https://codereview.appspot.com/9418050/diff/1/core/css/CSSRule.idl#oldcode39
core/css/CSSRule.idl:39: #if defined(ENABLE_CSS3_CONDITIONAL_RULES) && ENABLE_CSS3_CONDITIONAL_RULES
ditto for this ENABLE_
https://codereview.appspot.com/9418050/diff/1/core/dom/CustomElementConstructor.idl
File core/dom/CustomElementConstructor.idl (left):
https://codereview.appspot.com/9418050/diff/1/core/dom/CustomElementConstructor.idl#oldcode26
core/dom/CustomElementConstructor.idl:26: Conditional=CUSTOM_ELEMENTS,
and this one, also in DartCustomElement.h
https://codereview.appspot.com/9418050/diff/1/core/dom/DeviceMotionEvent.idl
File core/dom/DeviceMotionEvent.idl (left):
https://codereview.appspot.com/9418050/diff/1/core/dom/DeviceMotionEvent.idl#oldcode31
core/dom/DeviceMotionEvent.idl:31: [Custom] void initDeviceMotionEvent([Default=Undefined] optional DOMString type,
should custom bindings go away now?
https://codereview.appspot.com/9418050/diff/1/core/html/HTMLAudioElement.idl
File core/html/HTMLAudioElement.idl (left):
https://codereview.appspot.com/9418050/diff/1/core/html/HTMLAudioElement.idl#oldcode27
core/html/HTMLAudioElement.idl:27: Conditional=VIDEO,
and this ENABLE_VIDEO
https://codereview.appspot.com/9418050/diff/1/core/html/HTMLDialogElement.idl
File core/html/HTMLDialogElement.idl (left):
https://codereview.appspot.com/9418050/diff/1/core/html/HTMLDialogElement.idl#oldcode27
core/html/HTMLDialogElement.idl:27: Conditional=DIALOG_ELEMENT,
and this ENABLE_DIALOG_ELEMENT
https://codereview.appspot.com/9418050/diff/1/core/html/canvas/Uint8Array.idl
File core/html/canvas/Uint8Array.idl (left):
https://codereview.appspot.com/9418050/diff/1/core/html/canvas/Uint8Array.idl#oldcode29
core/html/canvas/Uint8Array.idl:29: NumericIndexedGetter,
are those annotations completely removed? it looks like we still have a logic for them in tools/dom/scripts.
https://codereview.appspot.com/9418050/diff/1/core/workers/SharedWorker.idl
File core/workers/SharedWorker.idl (left):
https://codereview.appspot.com/9418050/diff/1/core/workers/SharedWorker.idl#oldcode33
core/workers/SharedWorker.idl:33: Conditional=SHARED_WORKERS,
and this ENABLE
https://codereview.appspot.com/9418050/diff/1/modules/gamepad/Gamepad.idl
File modules/gamepad/Gamepad.idl (left):
https://codereview.appspot.com/9418050/diff/1/modules/gamepad/Gamepad.idl#oldcode27
modules/gamepad/Gamepad.idl:27: Conditional=GAMEPAD,
and this ENABLE
https://codereview.appspot.com/9418050/diff/1/modules/indexeddb/WorkerContextIndexedDatabase.idl
File modules/indexeddb/WorkerContextIndexedDatabase.idl (left):
https://codereview.appspot.com/9418050/diff/1/modules/indexeddb/WorkerContextIndexedDatabase.idl#oldcode28
modules/indexeddb/WorkerContextIndexedDatabase.idl:28: Supplemental=WorkerContext
if Supplemental is completely off WebKit IDLs, shouldn't we stop supporting it in our scripts/dart.idl?
https://codereview.appspot.com/9418050/diff/1/modules/speech/SpeechSynthesis.idl
File modules/speech/SpeechSynthesis.idl (left):
https://codereview.appspot.com/9418050/diff/1/modules/speech/SpeechSynthesis.idl#oldcode27
modules/speech/SpeechSynthesis.idl:27: Conditional=SPEECH_SYNTHESIS
ENABLE again?
https://codereview.appspot.com/9418050/diff/1/modules/webaudio/AudioBufferSourceNode.idl
File modules/webaudio/AudioBufferSourceNode.idl (left):
https://codereview.appspot.com/9418050/diff/1/modules/webaudio/AudioBufferSourceNode.idl#oldcode51
modules/webaudio/AudioBufferSourceNode.idl:51: #if defined(ENABLE_LEGACY_WEB_AUDIO) && ENABLE_LEGACY_WEB_AUDIO
another ENABLE?