Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(45)

Issue 94170043: code review 94170043: runtime: say when a goroutine is locked to OS thread (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by dvyukov
Modified:
10 years, 11 months ago
Reviewers:
gobot, rsc
CC:
golang-codereviews, rsc
Visibility:
Public.

Description

runtime: say when a goroutine is locked to OS thread Say when a goroutine is locked to OS thread in crash reports and goroutine profiles. It can be useful to understand what goroutines consume OS threads (syscall and locked), e.g. if you forget to call UnlockOSThread or leak locked goroutines.

Patch Set 1 #

Patch Set 2 : diff -r d797b2316601 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r c19c9a063fe8 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r c19c9a063fe8 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 78bb16ca0ae8 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/pkg/runtime/proc.c View 1 2 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 4
dvyukov
Hello golang-codereviews@googlegroups.com (cc: rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 11 months ago (2014-06-22 05:50:52 UTC) #1
rsc
LGTM
10 years, 11 months ago (2014-06-26 14:56:27 UTC) #2
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=c53623a08752 *** runtime: say when a goroutine is locked to OS thread ...
10 years, 11 months ago (2014-06-26 18:47:24 UTC) #3
gobot
10 years, 11 months ago (2014-06-26 18:57:56 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the openbsd-386-rootbsd builder.
See http://build.golang.org/log/006ce117e176d0632bfc8ae7625d2c1a25cc9da3
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b