Converted login/logout to use routes

Converted login/logout to use routes

Login/Logout is now controlled via the routing system
this caused a number of issues with the order of
operations for the auth system so I would love
another QA using all three back ends please.

https://code.launchpad.net/~hatch/juju-gui/auth-routes/+merge/163732

(do not edit description out of merge proposal)

[jeff.pihach, 2013-05-14 15:15:28]

Please take a look.

[jeff.pihach, 2013-05-14 20:31:27]

Please take a look.

[bcsaller, 2013-05-14 20:53:36]

QA Issues

1) Improv + large.json
2) View a service
3) Logout
4) Get /login/:gui:/... url resulting in a blank page

Need to clear the namespace on login/logout navigation

[jeff.pihach, 2013-05-14 21:44:56]

Please take a look.

[bcsaller, 2013-05-14 22:03:46]

LGTM

We may want a note in HACKING about having to disable navigate for testing as
this happens quite a few places and people are likely to hit it again.

[jeff.pihach, 2013-05-14 22:26:12]

Please take a look.

[matthew.scott, 2013-05-14 23:24:54]

Code LGTM - no QA for now, but might get to it later.

https://codereview.appspot.com/9415043/diff/16001/app/app.js
File app/app.js (right):

https://codereview.appspot.com/9415043/diff/16001/app/app.js#newcode825
app/app.js:825: this.showRootView();
What does this mean for the story of getting pasted a link by a coworker, then
having to log in and losing the link?  As long as this is acceptable, cool.

https://codereview.appspot.com/9415043/diff/16001/app/app.js#newcode875
app/app.js:875: @param {function} next callable for the next route Rin the
chain.
Revert.

https://codereview.appspot.com/9415043/diff/16001/test/test_app.js
File test/test_app.js (right):

https://codereview.appspot.com/9415043/diff/16001/test/test_app.js#newcode171
test/test_app.js:171: // app = new Y.juju.App(
Do we need this?

https://codereview.appspot.com/9415043/diff/16001/test/test_app.js#newcode349
test/test_app.js:349: it('login method hanlder is called after successful
login', function(done) {
Not a huge fan of the wording, since the 'it' is intended to be part of the test
name.  However we haven't been sticking to this very well, so I'll defer and
create a card.

[jeff.pihach, 2013-05-14 23:56:41]

Thanks for the reviews guys - I will await the QA from you Matt before I merge
just to be safe.

https://codereview.appspot.com/9415043/diff/16001/app/app.js
File app/app.js (right):

https://codereview.appspot.com/9415043/diff/16001/app/app.js#newcode825
app/app.js:825: this.showRootView();
I was wondering the same - I have created a card to discuss Friday

https://codereview.appspot.com/9415043/diff/16001/app/app.js#newcode875
app/app.js:875: @param {function} next callable for the next route Rin the
chain.
On 2013/05/14 23:24:54, matthew.scott wrote:
> Revert.

Done.

https://codereview.appspot.com/9415043/diff/16001/test/test_app.js
File test/test_app.js (right):

https://codereview.appspot.com/9415043/diff/16001/test/test_app.js#newcode171
test/test_app.js:171: // app = new Y.juju.App(
Nope removed.

[jeff.pihach, 2013-05-14 23:59:25]

Please take a look.

[jeff.pihach, 2013-05-15 15:18:05]

*** Submitted:

Converted login/logout to use routes

Login/Logout is now controlled via the routing system
this caused a number of issues with the order of
operations for the auth system so I would love
another QA using all three back ends please.

R=bcsaller, matthew.scott
CC=
https://codereview.appspot.com/9415043