CSS cleanup and shuffle.

CSS cleanup and shuffle.

Did a bunch of CSS cleanup and shuffling. Moved some general parts into their own files, tried to reduce any repetition and make usage consistent. I had planned to do more, but this should do for now.

https://code.launchpad.net/~huwshimi/juju-gui/css-refactoring/+merge/164071

(do not edit description out of merge proposal)

[huwshimi, 2013-05-16 06:01:06]

Please take a look.

[gary.poster, 2013-05-16 12:34:31]

LGTM assuming it QAs.  Hoping that someone from orange can QA since they have a
better idea of current state, but if someone asks, I'll give it a whirl.

Thank you!

Gary

https://codereview.appspot.com/9406047/diff/1/lib/views/browser/tabview.less
File lib/views/browser/tabview.less (right):

https://codereview.appspot.com/9406047/diff/1/lib/views/browser/tabview.less#...
lib/views/browser/tabview.less:2: margin-top: 25px;
Trivial, but I thought I was guessing that you moved margin-left and padding, in
.yui3-tab-label and -yui3-tab-selected below, so that it came after the
sub-section.  That's not what you do here.  What is the rationale for moving the
other stuff, then?

[huwshimi, 2013-05-17 04:00:04]

On 2013/05/16 12:34:31, gary.poster wrote:
> LGTM assuming it QAs.  Hoping that someone from orange can QA since they have
a
> better idea of current state, but if someone asks, I'll give it a whirl.
> 
> Thank you!
> 
> Gary
> 
> https://codereview.appspot.com/9406047/diff/1/lib/views/browser/tabview.less
> File lib/views/browser/tabview.less (right):
> 
>
https://codereview.appspot.com/9406047/diff/1/lib/views/browser/tabview.less#...
> lib/views/browser/tabview.less:2: margin-top: 25px;
> Trivial, but I thought I was guessing that you moved margin-left and padding,
in
> .yui3-tab-label and -yui3-tab-selected below, so that it came after the
> sub-section.  That's not what you do here.  What is the rationale for moving
the
> other stuff, then?

The pattern I've adopted is:

.class {
    .mixins;
    properties: values;

    .sub-classes {
    }
}

So in that change I was moving the mixins to the top of the class definition
where as the margin was added before the sub classes. Does that make sense?

[gary.poster, 2013-05-17 17:03:08]

On 2013/05/17 04:00:04, huwshimi wrote:
> On 2013/05/16 12:34:31, gary.poster wrote:
> > LGTM assuming it QAs.  Hoping that someone from orange can QA since they
have
> a
> > better idea of current state, but if someone asks, I'll give it a whirl.
> > 
> > Thank you!
> > 
> > Gary
> > 
> > https://codereview.appspot.com/9406047/diff/1/lib/views/browser/tabview.less
> > File lib/views/browser/tabview.less (right):
> > 
> >
>
https://codereview.appspot.com/9406047/diff/1/lib/views/browser/tabview.less#...
> > lib/views/browser/tabview.less:2: margin-top: 25px;
> > Trivial, but I thought I was guessing that you moved margin-left and
padding,
> in
> > .yui3-tab-label and -yui3-tab-selected below, so that it came after the
> > sub-section.  That's not what you do here.  What is the rationale for moving
> the
> > other stuff, then?
> 
> The pattern I've adopted is:
> 
> .class {
>     .mixins;
>     properties: values;
> 
>     .sub-classes {
>     }
> }
> 
> So in that change I was moving the mixins to the top of the class definition
> where as the margin was added before the sub classes. Does that make sense?

Ah!  yes.  Probably worth documenting...and maybe worth finding a place to
document it. :-)  Want to add a doc in the docs directory about this?  or is
there something there already that you can co-opt?  (This can be a separate
branch or the same one, whichever.)

[curtis, 2013-05-20 20:48:41]

Thank you Huw. LGTM.

Sorry about the delay in the review. I had to fix my juju-gui environment to
view this. Do you need help landing this? You an ping me for help if needed.

[huwshimi, 2013-05-21 03:44:20]

*** Submitted:

CSS cleanup and shuffle.

Did a bunch of CSS cleanup and shuffling. Moved some general parts into their
own files, tried to reduce any repetition and make usage consistent. I had
planned to do more, but this should do for now.

R=gary.poster, curtis
CC=
https://codereview.appspot.com/9406047