code review 9406046: runtime: enable stack scanning by frames

runtime: enable stack scanning by frames

Update issue 5134

[cshapiro1, 2013-05-14 23:29:24]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-05-14 23:34:15]

LGTM

*popcorn*



On Tue, May 14, 2013 at 4:29 PM, <cshapiro@google.com> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> runtime: enable stack scanning by frames
>
> Please review this at
https://codereview.appspot.**com/9406046/<https://codereview.appspot.com/9406...
>
> Affected files:
>   M src/pkg/runtime/mgc0.c
>
>
> Index: src/pkg/runtime/mgc0.c
> ==============================**==============================**=======
> --- a/src/pkg/runtime/mgc0.c
> +++ b/src/pkg/runtime/mgc0.c
> @@ -18,7 +18,7 @@
>         Debug = 0,
>         DebugMark = 0,  // run second pass to check mark
>         CollectStats = 0,
> -       ScanStackByFrames = 0,
> +       ScanStackByFrames = 1,
>         IgnorePreciseGC = 0,
>
>         // Four bits per word (see #defines below).
> @@ -1459,6 +1459,8 @@
>                 }
>         }
>         if (ScanStackByFrames) {
> +               USED(stk);
> +               USED(guard);
>                 doframe = false;
>                 runtime·gentraceback(pc, sp, nil, gp, 0, nil, 0x7fffffff,
> addframeroots, &doframe);
>         } else {
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[cshapiro1, 2013-05-14 23:38:15]

*** Submitted as https://code.google.com/p/go/source/detail?r=909d1af80cd0 ***

runtime: enable stack scanning by frames

Update issue 5134

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/9406046