Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 9387043: code review 9387043: [release-branch.go1.1] runtime/race: improve public doc... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by adg
Modified:
9 years, 8 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

[release-branch.go1.1] runtime/race: improve public documentation ««« CL 9144050 / d29da2ced72b runtime/race: improve public documentation Move the documentation from race.go to doc.go, because race.go uses +build race, so it's not normally parsed by go doc. Rephrase the documentation for end users, provide link to race detector manual. Fixes issue 5444. R=golang-dev, minux.ma, adg, r CC=golang-dev https://codereview.appspot.com/9144050 »»»

Patch Set 1 #

Patch Set 2 : diff -r 9cad11773066 https://code.google.com/p/go #

Patch Set 3 : diff -r 9cad11773066 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
A src/pkg/runtime/race/doc.go View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/pkg/runtime/race/race.go View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 8 months ago (2013-05-13 16:25:02 UTC) #1
bradfitz
LGTM On May 13, 2013 9:25 AM, <adg@golang.org> wrote: > Reviewers: golang-dev1, > > Message: ...
9 years, 8 months ago (2013-05-13 16:31:04 UTC) #2
adg
9 years, 8 months ago (2013-05-13 16:35:25 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=a3df1aafb2f6 ***

[release-branch.go1.1] runtime/race: improve public documentation

««« CL 9144050 / d29da2ced72b
runtime/race: improve public documentation
Move the documentation from race.go to doc.go, because
race.go uses +build race, so it's not normally parsed by go doc.
Rephrase the documentation for end users, provide link to race
detector manual.
Fixes issue 5444.

R=golang-dev, minux.ma, adg, r
CC=golang-dev
https://codereview.appspot.com/9144050
»»»

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/9387043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b