Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(49)

Issue 93870044: code review 93870044: misc/cgo/test/backdoor: add gccgo version of backdoor f... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by iant
Modified:
11 years ago
Reviewers:
bradfitz
CC:
golang-codereviews, bradfitz
Visibility:
Public.

Description

misc/cgo/test/backdoor: add gccgo version of backdoor function For the gc compiler the Go function Issue7695 is defined in runtime.c, but there is no way to do that for gccgo, because there is no way to get the correct pkgpath. The test is not important for gccgo in any case.

Patch Set 1 #

Patch Set 2 : diff -r 6cf757123ad4 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
A misc/cgo/test/backdoor/backdoor_gccgo.go View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3
iant
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years ago (2014-04-27 05:18:39 UTC) #1
bradfitz
LGTM On Sat, Apr 26, 2014 at 10:18 PM, <iant@golang.org> wrote: > Reviewers: golang-codereviews, > ...
11 years ago (2014-04-27 05:20:21 UTC) #2
iant
11 years ago (2014-04-27 05:31:35 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=96cbc91bc15a ***

misc/cgo/test/backdoor: add gccgo version of backdoor function

For the gc compiler the Go function Issue7695 is defined in
runtime.c, but there is no way to do that for gccgo, because
there is no way to get the correct pkgpath.  The test is not
important for gccgo in any case.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/93870044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b