Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(271)

Issue 93800043: rename authorised-keys to authorized-keys

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by jameinel
Modified:
10 years ago
Reviewers:
mp+217174, fwereade
Visibility:
Public.

Description

rename authorised-keys to authorized-keys This addresses bug #1312537. We were very inconsistent about whether then name was "authorized-keys" or "authorised-keys". I can understand the cultural spelling biasies. I originally intended to just alias the command to 'authorized-keys' but then I realized the environments.yaml setting is 'authorized-keys' so I felt it would be best to be consistent with something we can't change at this point. The patch was written against 1.18, so it should be trivial to land it there, but I'm proposing it just against trunk to start with. We could also do a more-trivial patch that just adds 'authorized-keys' as the alias for 1.18, but it means that 'juju help authorized-keys' will tell you the command is called 'authorised-keys' which I feel should change in 1.19+. https://code.launchpad.net/~jameinel/juju-core/1.18-authorized-keys-1312537/+merge/217174 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -45 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/authorizedkeys.go View 2 chunks +7 lines, -6 lines 0 comments Download
M cmd/juju/authorizedkeys_add.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/authorizedkeys_delete.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/authorizedkeys_import.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/authorizedkeys_list.go View 2 chunks +2 lines, -2 lines 0 comments Download
M cmd/juju/authorizedkeys_test.go View 13 chunks +23 lines, -23 lines 0 comments Download
M cmd/juju/help_topics.go View 1 chunk +5 lines, -5 lines 0 comments Download
M cmd/juju/main.go View 1 chunk +2 lines, -2 lines 0 comments Download
M cmd/juju/main_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M cmd/supercommand.go View 4 chunks +6 lines, -1 line 0 comments Download
M cmd/supercommand_test.go View 1 chunk +23 lines, -0 lines 0 comments Download
M scripts/win-installer/setup.iss View 1 chunk +1 line, -1 line 0 comments Download
M version/version.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
jameinel
Please take a look.
10 years ago (2014-04-25 06:47:07 UTC) #1
fwereade
10 years ago (2014-04-25 07:34:27 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b