Issue 9379043: code review 9379043: go.net/ipv4: simplify socket option helpers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9379043: code review 9379043: go.net/ipv4: simplify socket option helpers (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by mikio

Modified:
11 years, 9 months ago

Reviewers:
dave

CC:
dave_cheney.net, golang-dev

Visibility:
Public.

Description

go.net/ipv4: simplify socket option helpers

Patch Set 1 : diff -r da2eb5dd9ea9 https://code.google.com/p/go.net #

Patch Set 2 : diff -r b8dd04764dae https://code.google.com/p/go.net #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -162 lines)			Patch
M	ipv4/sockopt_bsd.go	View	5 chunks	+15 lines, -43 lines	0 comments	Download
M	ipv4/sockopt_freebsd.go	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	ipv4/sockopt_linux.go	View	5 chunks	+10 lines, -38 lines	0 comments	Download
M	ipv4/sockopt_plan9.go	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	ipv4/sockopt_unix.go	View	4 chunks	+4 lines, -20 lines	0 comments	Download
M	ipv4/sockopt_windows.go	View	7 chunks	+20 lines, -53 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mikio

Hello dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

11 years, 9 months ago (2013-06-16 06:58:00 UTC) #1

mikio

On Sun, Jun 16, 2013 at 8:26 PM, <dave@cheney.net> wrote: > LGTM. Nice reduction in ...

11 years, 9 months ago (2013-06-16 11:43:02 UTC) #3

mikio

11 years, 9 months ago (2013-06-16 11:43:41 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=3e9614221450&repo=net ***

go.net/ipv4: simplify socket option helpers

R=dave
CC=golang-dev
https://codereview.appspot.com/9379043

Expand All Messages | Collapse All Messages