Issue 93770044: code review 93770044: cmd/go: add go build -i

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 93770044: code review 93770044: cmd/go: add go build -i (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by crawshaw1

Modified:
11 years ago

Reviewers:
iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

cmd/go: add go build -i Fixes issue 7071.

Patch Set 1 #

Patch Set 2 : diff -r 9eacb9c0d810 https://code.google.com/p/go #

Patch Set 3 : diff -r 9eacb9c0d810 https://code.google.com/p/go #

Patch Set 4 : diff -r 9eacb9c0d810 https://code.google.com/p/go #

Patch Set 5 : diff -r 9eacb9c0d810 https://code.google.com/p/go #

Patch Set 6 : diff -r 2b8ee33fbca8 https://code.google.com/p/go #

Patch Set 7 : diff -r e5a8fd95939f https://code.google.com/p/go #

Patch Set 8 : diff -r e5a8fd95939f https://code.google.com/p/go #

Patch Set 9 : diff -r e5a8fd95939f https://code.google.com/p/go #

Patch Set 10 : diff -r e5a8fd95939f https://code.google.com/p/go #

Patch Set 11 : diff -r e5a8fd95939f https://code.google.com/p/go #

Patch Set 12 : diff -r e5a8fd95939f https://code.google.com/p/go #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -5 lines)			Patch
M	src/cmd/go/build.go	View	1 2	5 chunks	+11 lines, -2 lines	0 comments	Download
M	src/cmd/go/test.bash	View	1 2 3 4	1 chunk	+40 lines, -0 lines	0 comments	Download
M	src/cmd/go/test.go	View	1 2	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/cmd/go/testflag.go	View	1	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

crawshaw1

Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years ago (2014-04-25 00:10:06 UTC) #1

crawshaw1

On Thu, Apr 24, 2014 at 6:20 PM, <iant@golang.org> wrote: > Should this have a ...

11 years ago (2014-04-25 05:39:24 UTC) #3

crawshaw1

11 years ago (2014-05-06 13:12:30 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=d797b2316601 ***

cmd/go: add go build -i

Fixes issue 7071.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/93770044

Expand All Messages | Collapse All Messages