Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(75)

Issue 93720045: code review 93720045: runtime: make MemStats.LastGC Unix time again (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by dvyukov
Modified:
11 years ago
Reviewers:
minux1, gobot, iant
CC:
minux1, rsc, iant, golang-codereviews
Visibility:
Public.

Description

runtime: make MemStats.LastGC Unix time again The monotonic clock patch changed all runtime times to abstract monotonic time. As the result user-visible MemStats.LastGC become monotonic time as well. Restore Unix time for LastGC. This is the simplest way to expose time.now to runtime that I found. Another option would be to change time.now to C called int64 runtime.unixnanotime() and then express time.now in terms of it. But this would require to introduce 2 64-bit divisions into time.now. Another option would be to change time.now to C called void runtime.unixnanotime1(struct {int64 sec, int32 nsec} *now) and then express both time.now and runtime.unixnanotime in terms of it. Fixes issue 7852.

Patch Set 1 #

Patch Set 2 : diff -r f613443bb13a https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r f613443bb13a https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r 9eacb9c0d810 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 15e9d3c5d705 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M src/pkg/runtime/asm_386.s View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/runtime/asm_amd64.s View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/runtime/asm_amd64p32.s View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/runtime/asm_arm.s View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/pkg/runtime/gc_test.go View 1 2 chunks +13 lines, -0 lines 0 comments Download
M src/pkg/runtime/mgc0.c View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/pkg/runtime/mgc0.go View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8
dvyukov
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
11 years ago (2014-04-24 10:30:58 UTC) #1
minux1
https://codereview.appspot.com/93720045/diff/40001/src/pkg/runtime/asm_arm.s File src/pkg/runtime/asm_arm.s (right): https://codereview.appspot.com/93720045/diff/40001/src/pkg/runtime/asm_arm.s#newcode752 src/pkg/runtime/asm_arm.s:752: JMP time·now(SB) s/JMP/B/
11 years ago (2014-04-25 06:12:41 UTC) #2
dvyukov
https://codereview.appspot.com/93720045/diff/40001/src/pkg/runtime/asm_arm.s File src/pkg/runtime/asm_arm.s (right): https://codereview.appspot.com/93720045/diff/40001/src/pkg/runtime/asm_arm.s#newcode752 src/pkg/runtime/asm_arm.s:752: JMP time·now(SB) On 2014/04/25 06:12:41, minux wrote: > s/JMP/B/ ...
11 years ago (2014-04-25 06:15:10 UTC) #3
minux1
LGTM, but please wait for rsc or iant to sign off.
11 years ago (2014-04-25 06:42:31 UTC) #4
dvyukov
On 2014/04/25 06:42:31, minux wrote: > LGTM, but please wait for rsc or iant to ...
11 years ago (2014-05-01 17:13:12 UTC) #5
iant
LGTM
11 years ago (2014-05-01 17:28:09 UTC) #6
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=a80c7c32d1cc *** runtime: make MemStats.LastGC Unix time again The monotonic clock patch ...
11 years ago (2014-05-02 16:32:57 UTC) #7
gobot
11 years ago (2014-05-02 20:05:37 UTC) #8
Message was sent while issue was closed.
This CL appears to have broken the plan9-386-cnielsen builder.
See http://build.golang.org/log/3b591e6c8d6db684bcc679ebda658c4134b91cf0
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b