Issue 93680045: code review 93680045: go.net/html: Fix comment handling for "in select" inser...

https://codereview.appspot.com/93680045/diff/30001/html/parse.go File html/parse.go (right): https://codereview.appspot.com/93680045/diff/30001/html/parse.go#newcode1621 html/parse.go:1621: p.addChild(&Node{ I must admit that it's been a while ...

9 years, 10 months ago (2014-06-10 04:27:59 UTC) #3

frederickm

On 2014/06/10 04:27:59, nigeltao wrote: > https://codereview.appspot.com/93680045/diff/30001/html/parse.go > File html/parse.go (right): > > https://codereview.appspot.com/93680045/diff/30001/html/parse.go#newcode1621 > ...

9 years, 10 months ago (2014-06-10 06:06:43 UTC) #4

andybalholm

LGTM. I think that doc.AppendChild was a copy-paste error when InSelectIM was created.

9 years, 10 months ago (2014-06-10 15:40:20 UTC) #5

nigeltao

9 years, 10 months ago (2014-06-12 01:57:16 UTC) #7

*** Submitted as
https://code.google.com/p/go/source/detail?r=0d5da82b4799&repo=net ***

go.net/html: Fix comment handling for "in select" insertion mode

LGTM=andybalholm, nigeltao
R=golang-codereviews, gobot, nigeltao, andybalholm
CC=golang-codereviews
https://codereview.appspot.com/93680045

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages

Issue 93680045: code review 93680045: go.net/html: Fix comment handling for "in select" inser...

Description

Patch Set 1 #

Patch Set 2 : diff -r 9c0f9daaa74b https://code.google.com/p/go.net #

Patch Set 3 : diff -r 9c0f9daaa74b https://code.google.com/p/go.net #

Messages