Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(59)

Issue 9358043: code review 9358043: cmd/gc: eliminate a useless bounds check in inlined app... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 5 months ago by remyoudompheng
Modified:
8 years, 5 months ago
Reviewers:
r, DMorsing
CC:
golang-dev, DMorsing, r
Visibility:
Public.

Description

cmd/gc: eliminate a useless bounds check in inlined append().

Patch Set 1 #

Patch Set 2 : diff -r 30c566874b83 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 30c566874b83 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 7d87f5bc43b6 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/gc/walk.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
8 years, 5 months ago (2013-05-12 14:22:50 UTC) #1
remyoudompheng
For the following code: var s []int var x int func F() { s = ...
8 years, 5 months ago (2013-05-12 14:23:57 UTC) #2
remyoudompheng
ping? This one should be easy.
8 years, 5 months ago (2013-05-20 08:38:20 UTC) #3
DMorsing
LGTM
8 years, 5 months ago (2013-05-20 11:39:53 UTC) #4
r
LGTM
8 years, 5 months ago (2013-05-20 15:46:59 UTC) #5
remyoudompheng
8 years, 5 months ago (2013-05-20 21:21:11 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=e2dc4e728932 ***

cmd/gc: eliminate a useless bounds check in inlined append().

R=golang-dev, daniel.morsing, r
CC=golang-dev
https://codereview.appspot.com/9358043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b