Issue 93520047: provider/azure: fix tests for go1.3/gccgo

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 93520047: provider/azure: fix tests for go1.3/gccgo

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by axw

Modified:
9 years, 11 months ago

Reviewers:
mp+220552, dave

Visibility:
Public.

Description

provider/azure: fix tests for go1.3/gccgo Fix a test to use SameContents instead of DeepEquals. Also, make StopInstances deterministic; it now stops instances in the order of IDs specified. One of the StopInstances tests was sending responses in the wrong order, and that has been rectified. Fixes lp:1303583 https://code.launchpad.net/~axwalk/juju-core/lp1303583-provider-azure-tests-gccgo/+merge/220552 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : provider/azure: fix tests for go1.3/gccgo #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -6 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	provider/azure/environ.go	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	provider/azure/environ_test.go	View		3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dave_cheney.net

LGTM. https://codereview.appspot.com/93520047/diff/1/provider/azure/environ.go File provider/azure/environ.go (right): https://codereview.appspot.com/93520047/diff/1/provider/azure/environ.go#newcode772 provider/azure/environ.go:772: serviceNames := make([]string, 0) var serviceNames []string

9 years, 11 months ago (2014-05-22 04:30:03 UTC) #2

axw

9 years, 11 months ago (2014-05-22 04:41:39 UTC) #3

Please take a look.

https://codereview.appspot.com/93520047/diff/1/provider/azure/environ.go
File provider/azure/environ.go (right):

https://codereview.appspot.com/93520047/diff/1/provider/azure/environ.go#newc...
provider/azure/environ.go:772: serviceNames := make([]string, 0)
On 2014/05/22 04:30:03, dfc wrote:
> var serviceNames []string
> 

Done.

Expand All Messages | Collapse All Messages