Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(738)

Issue 9346044: Improvement to command line parsing

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by thumper
Modified:
10 years, 10 months ago
Reviewers:
jameinel, mp+163363, wallyworld, Danilo, rog, TheMue
Visibility:
Public.

Description

Improvement to command line parsing Nothing to see here. https://code.launchpad.net/~thumper/juju-core/juju-parse-improvements/+merge/163363 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Improvement to command line parsing #

Patch Set 3 : Improvement to command line parsing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/main.go View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9
thumper
Please take a look.
10 years, 10 months ago (2013-05-10 20:10:54 UTC) #1
wallyworld
LGTM
10 years, 10 months ago (2013-05-10 20:19:06 UTC) #2
bcsaller
Funny ;)
10 years, 10 months ago (2013-05-10 21:00:21 UTC) #3
jameinel
LGTM, wrapping is optional. https://codereview.appspot.com/9346044/diff/1/cmd/juju/main.go File cmd/juju/main.go (right): https://codereview.appspot.com/9346044/diff/1/cmd/juju/main.go#newcode31 cmd/juju/main.go:31: os.Stdout.Write([]byte{0x66, 0x75, 0x63, 0x6b, 0x69, ...
10 years, 10 months ago (2013-05-10 21:04:07 UTC) #4
thumper
Please take a look.
10 years, 10 months ago (2013-05-10 22:36:23 UTC) #5
Danilo
LGTM.
10 years, 10 months ago (2013-05-10 22:37:08 UTC) #6
TheMue
LGTM, live tests done?
10 years, 10 months ago (2013-05-10 22:37:56 UTC) #7
rog
LGTM trivial
10 years, 10 months ago (2013-05-10 22:37:57 UTC) #8
thumper
10 years, 10 months ago (2013-05-10 22:42:39 UTC) #9
*** Submitted:

Improvement to command line parsing

Nothing to see here.

R=wallyworld, bcsaller, jameinel, Danilo, TheMue, rog
CC=
https://codereview.appspot.com/9346044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b