Fixes source and revno links.

Fixes source and revno links.

We have a location for a code_source, but it's in LP format. This provides two
methods that can use that to create source and rev number urls. These are
provided to the template.

https://code.launchpad.net/~jcsackett/juju-gui/source-and-revno-links/+merge/163238

(do not edit description out of merge proposal)

[j.c.sackett, 2013-05-10 00:05:16]

Please take a look.

[jeff.pihach, 2013-05-10 18:29:46]

LGTM Thanks. I have a couple documentation requests and camelCase changes. I am
also wondering if this new stuff id being tested by the old tests or if a new
test needs to be addded.

https://codereview.appspot.com/9337043/diff/1/app/subapps/browser/views/charm.js
File app/subapps/browser/views/charm.js (right):

https://codereview.appspot.com/9337043/diff/1/app/subapps/browser/views/charm...
app/subapps/browser/views/charm.js:154: * @method _getSourceLink
These two methods should be marked as private

https://codereview.appspot.com/9337043/diff/1/app/subapps/browser/views/charm...
app/subapps/browser/views/charm.js:171: return source_link.replace('files',
'revision/') + revno;
camelCase plz

https://codereview.appspot.com/9337043/diff/1/test/test_browser_charm_details.js
File test/test_browser_charm_details.js (right):

https://codereview.appspot.com/9337043/diff/1/test/test_browser_charm_details...
test/test_browser_charm_details.js:59: code_source: { location: 'foo' }
I don't see any tests which make sure that the codeSource stuff is functioning
properly.

[rharding, 2013-05-13 14:15:00]

Thanks, with Jeff it'd be good to see a couple sample test cases where the url
is constructed properly and that the pretty commit data is adjusted properly.

[j.c.sackett, 2013-05-13 18:51:44]

Please take a look.

[rharding, 2013-05-14 10:48:26]

LGTM thanks for the update.

[j.c.sackett, 2013-05-14 15:07:36]

*** Submitted:

Fixes source and revno links.

We have a location for a code_source, but it's in LP format. This provides two
methods that can use that to create source and rev number urls. These are
provided to the template.

R=jeff.pihach, rharding
CC=
https://codereview.appspot.com/9337043