Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1808)

Issue 9326043: Unset all keypair environment variables for tests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 12 months ago by Danilo
Modified:
10 years, 10 months ago
Reviewers:
mp+163190, wallyworld, TheMue
Visibility:
Public.

Description

Unset all keypair environment variables for tests. Unset newly supported environment variables for tests in environs/openstack/config_test.go: AWS_SECRET_ACCESS_KEY, EC2_SECRET_KEYS, NOVA_API_KEY, OS_ACCESS_KEY, OS_SECRET_KEY. https://code.launchpad.net/~danilo/juju-core/unset-env-for-tests/+merge/163190 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Unset all keypair environment variables for tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/openstack/config_test.go View 1 chunk +14 lines, -9 lines 0 comments Download

Messages

Total messages: 4
Danilo
Please take a look.
10 years, 12 months ago (2013-05-09 17:27:27 UTC) #1
wallyworld
LGTM
10 years, 12 months ago (2013-05-09 17:28:53 UTC) #2
TheMue
LGTM
10 years, 12 months ago (2013-05-09 17:31:19 UTC) #3
Danilo
10 years, 12 months ago (2013-05-09 17:32:48 UTC) #4
*** Submitted:

Unset all keypair environment variables for tests.

Unset newly supported environment variables for tests in
environs/openstack/config_test.go: AWS_SECRET_ACCESS_KEY, EC2_SECRET_KEYS,
NOVA_API_KEY, OS_ACCESS_KEY, OS_SECRET_KEY.

R=wallyworld, TheMue
CC=
https://codereview.appspot.com/9326043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b