Issue 9315043: code review 9315043: [release-branch.go1.1] net: fix dial race on plan9 and ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9315043: code review 9315043: [release-branch.go1.1] net: fix dial race on plan9 and ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by adg

Modified:
11 years, 10 months ago

Reviewers:

CC:
golang-dev

Visibility:
Public.

Description

[release-branch.go1.1] net: fix dial race on plan9 and windows ««« CL 9159043 / f1ddc3ce3dfe net: fix dial race on plan9 and windows Fixes issue 5349. R=golang-dev, lucio.dere, dsymonds, bradfitz, iant, adg, dave, r CC=golang-dev https://codereview.appspot.com/9159043 »»»

Patch Set 1 #

Patch Set 2 : diff -r 9e1dac980adb https://code.google.com/p/go #

Patch Set 3 : diff -r 9e1dac980adb https://code.google.com/p/go #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -3 lines)			Patch
	M	src/pkg/net/dial_gen.go	View	1	2 chunks	+15 lines, -3 lines	0 comments	Download
	A	src/pkg/net/dial_gen_test.go	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 10 months ago (2013-05-08 22:58:12 UTC) #1

adg

11 years, 10 months ago (2013-05-08 22:58:47 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=f34a588b0c9e ***

[release-branch.go1.1] net: fix dial race on plan9 and windows

««« CL 9159043 / f1ddc3ce3dfe
net: fix dial race on plan9 and windows

Fixes issue 5349.

R=golang-dev, lucio.dere, dsymonds, bradfitz, iant, adg, dave, r
CC=golang-dev
https://codereview.appspot.com/9159043
»»»

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/9315043

Expand All Messages | Collapse All Messages